Molinari

Molinari

1M Downloads

Lockpicking no longer working in Classic Era version.

HolteUnderscore opened this issue ยท 10 comments

commented

Describe the bug

Following the last 2 updates, lockpicking is no longer working in the Classic Era version.
Not tried it in the other versions of WoW. I'm using the standard "Alt" keybind.

How to reproduce

Anytime I try to unlock a locked box.

What did you expect?

I expected the box to be engagable with Molinari but, it isn't any longer.

Screenshots

commented

same thing for discenchanting, problem is in salvages not existing in classic era in file World of Warcraft_classic_era_\Interface\AddOns\Molinari\api\items.lua:IsSalvagable() + there is problem with items quality, addon uses new format while game uses old as seen here
image

commented

Thanks for spending some time looking at this, it's invaluable since I don't run classic.

I'll take a look when time allows it, please use the <100100 versions in the mean time.

commented

@p3lim i managed to have it working with work around, sharing file for compare
i commented out unsupported salvages and updated Classic era equivalent of Uncommon but itll need some control here based on game version if multiple are supported
https://codeshare.io/8p3B1e expiers in 24h tho

commented

there is also an issue in wrath classic, line:56 item.lua throws and error

figured a simple fix change Enum.Enum.ItemQuality.Uncommon to Enum.ItemQuality.Good save file /reload UI and works
i believe this would also fix the lockpicking part as well

commented

no error on attempt, dont have green to spare for Dis, will report back asap

commented

image
cant prospect on classic era :P
In Vanilla there was only Disenchant and LockPick

commented

thanks for the fast update ;) this works for disenchanting in wrath

commented

same, works for Dis in classic era