Musician

Musician

376k Downloads

[Bug] Notification/Client info font height inconsistent with base TRP 3.0.0+

Raenore opened this issue ยท 0 comments

commented

Description

As of TRP 3.0.0, we've hardcoded the font height of the notification (and version line) in tooltips to 10 (As opposed to making it honor getSmallLineFontSize()).

This change hasn't trickled down to Musician, so if you now see the version strings it does seem a bit inconsistent/off.

Relevant PRs of the change we made:
Total-RP/Total-RP-3#1051
Total-RP/Total-RP-3#1060

Reproduction steps

Look at the bottom of the tooltip from a Musician user.

Actual behavior

The two lines have the same font height.

Expected behavior

Additions to the notification / version info line should all have a font height set to 10.

Screenshots

image

World of Warcraft flavor

Retail

World of Warcraft version

11.0.0.55824

Add-on version

1.9.9.5

Have you tried disabling all your other add-ons to ensure only this add-on causes the issue?

Yes

Additional context

This is a minor nitpick at best, but we figured it best to inform you of this change.