Addon keeps resetting settings.
Warpavp2 opened this issue ยท 11 comments
Describe the bug
A clear and concise description of what the bug is.
When disabling spells they all reset back on after closing the window for spell selection.
To Reproduce
Steps to reproduce the behavior:
- Go to '...' Open NamePlateCooldowns Window
- Click on '....' Turn on or off some spells.
- Scroll down to '....' Close window and reopen a few times. Or do an arena idk.
- See error Everything goes back to ON.
Expected behavior
A clear and concise description of what you expected to happen.
The spells should stay off if you have them off.
Screenshots
If applicable, add screenshots to help explain your problem.
Do we have any update? :)
I hope it's gonna be fixed, I would like to use the addon, it's amazing :) but now I can't till the settings are keeping reseting.
If I can help anything let me know.
Hello.
I cannot reproduce this bug currently. I have opened the list of spells and then tried to enable/disable some spells. Their state was saved without any issue. Maybe I'm doing something wrong? Are you closing WoW client correctly? Addon settings are not saved if WoW client is crashed or closed, by example, by Alt-F4.
In case we could make a meeting to test it, I could share my screen in order to figure out where is the problem.
I don't have to close the WoW Client to reproduce the issue.
To be honest, I'm not sure when the issue is reproduced 100%, but that's what I've done:
- Installed the addon (via CurseForge)
- Opened the UI of it.
- Opened the spells section
- Double clicked the "Disable all" -> worked fine
- Then I just configured all the spells for all the classes one by one. (enabled some spells for each classes) - here what was interesting that some spells appeared multiple times.
- Then I left the Spells section, or by closing the Addon interface or by navigating to another tab on the addon's UI.
- When I moved back to the spells section sometimes everything was fine (as I configured it) sometimes the settings was resetting.
As I observed it was also enough if I pressed the Test Mode again and again while I was into the spells tab and the settings has been resetted.
I'm not sure if any of the above interaction forces the addon to reset the configs or it just resets it periodically (1-2m).
Totally I've tried to configure all the required spells 4 times (for all the classes) and all the configs has been reseted all of the times.
I truly hope that I succeeded to help. (I'm not the best QA while I'm also a developer :) )
nameplatecooldowns_config_ressetting_bug.mp4
I've created a video about the bug. It's compressed, that's why it's so blurry. But I think you will be able to figure out what was happened exactly. (maybe the concretely selected spells matters?)
The video was made exactly after I've clearly reinstalled the addon.
I've also found out that if I do not use the disable all feature but I manually disable all the spells the settings are not reseted. (or until now they were not reseted) BUT some of the spells constantly becomes active even if I disable them, like the mage's counterspell the DK's stunn. (this happened when I pressed the test mode button)
Ah, I guess you've found a very old 'bug' I was too lazy to fix. If test mode is enabled, all changes in spells will be lost after disabling test mode. I think I'll just disable the ability to edit spells while test mode is active.
I think I'll just disable the ability to edit spells while test mode is active.