pvp trinket is not shown

Question

pvp trinket is not shown

piddi19900 opened this issue 3 years ago · 21 comments

piddi19900 commented 3 years ago

Describe the bug
PVP trinket is not shown up on the nameplate, although it is enabled in the settings

To Reproduce
Steps to reproduce the behavior:

Go to the settings and enable pvp trinket
Make a duel or pvp/arena and check the nameplate, it does not work

Expected behavior
The use of enemy pvp trinket should be shown up, same as all other spells

casualshammy · Answer 1 · 2021-09-20T09:57:23.000Z

Could you please write a name of your pvp trinket? Because my trinket works fine, although I don't play pvp now.

piddi19900 · Answer 2 · 2021-09-20T12:31:35.000Z

The issue is in pvp/arena, I can't see the pvp trinket cooldown on the enemy nameplate Pkry ***@***.***> schrieb am Mo., 20. Sept. 2021, 14:30:

…

Hi, that was quick. The name is "Medaillon der Horde" (I play on german client) or on alliance side it's "Medaillon der Allianz". Does this help? :) casualshammy ***@***.***> schrieb am Mo., 20. Sept. 2021, 11:57: > Could you please write a name of your pvp trinket? Because my trinket > works fine, although I don't play pvp now. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#89 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AVWXE24WRVNE2UYKLJNCIMDUC4AQ3ANCNFSM5ELSM6YA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >

piddi19900 · Answer 3 · 2021-09-20T12:30:22.000Z

Hi, that was quick. The name is "Medaillon der Horde" (I play on german client) or on alliance side it's "Medaillon der Allianz". Does this help? :) casualshammy ***@***.***> schrieb am Mo., 20. Sept. 2021, 11:57:

…

Could you please write a name of your pvp trinket? Because my trinket works fine, although I don't play pvp now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVWXE24WRVNE2UYKLJNCIMDUC4AQ3ANCNFSM5ELSM6YA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

casualshammy · Answer 4 · 2021-09-20T12:49:26.000Z

The name is "Medaillon der Horde" (I play on german client) or on alliance side it's "Medaillon der Allianz".

Item lvl? Maybe different trinkets have different spell ids.

The issue is in pvp/arena, I can't see the pvp trinket cooldown on the enemy nameplate

"Pvp" = "battleground"? I've tested it in duel a week ago because of this issue. Maybe on bg/arena trinket triggers spell with different id. I'll check it tonight.

piddi19900 · Answer 5 · 2021-09-20T13:04:02.000Z

Does it work in a duel? I have never seen the pvp trinket in pvp at all, but I can test it in a duel tonight. Ok, perfect, thanks. casualshammy ***@***.***> schrieb am Mo., 20. Sept. 2021, 14:49:

…

"Pvp" = "battleground"? I've tested it in duel a week ago because of this issue <#86>. Maybe on bg/arena trinket triggers spell with different id. I'll check it tonight. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVWXE27OUWSU2HFSBL6A3WLUC4UWDANCNFSM5ELSM6YA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

piddi19900 · Answer 6 · 2021-09-20T16:58:36.000Z

Hey, It does not work in a duel, I have tested it right now. Hope this helps. Am Mo., 20. Sept. 2021 um 18:52 Uhr schrieb Pkry ***@***.***>:

…

Hey, Attached I send you a short video, in battleground it does not work. Am Mo., 20. Sept. 2021 um 15:03 Uhr schrieb Pkry ***@***.***>: > Does it work in a duel? I have never seen the pvp trinket in pvp at all, > but I can test it in a duel tonight. Ok, perfect, thanks. > > casualshammy ***@***.***> schrieb am Mo., 20. Sept. 2021, > 14:49: > >> "Pvp" = "battleground"? I've tested it in duel a week ago because of this >> issue <#86>. >> Maybe on bg/arena trinket triggers spell with different id. I'll check it >> tonight. >> >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <#89 (comment)>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AVWXE27OUWSU2HFSBL6A3WLUC4UWDANCNFSM5ELSM6YA> >> . >> Triage notifications on the go with GitHub Mobile for iOS >> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> >> or Android >> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. >> >> >

casualshammy · Answer 7 · 2021-09-22T19:08:55.000Z

I'll appreciate if you'll find time to try the latest beta (90100.12-beta)

piddi19900 · Answer 8 · 2021-09-24T11:40:21.000Z

Yes, I'll do this today, let you know outcome, thanks. casualshammy ***@***.***> schrieb am Mi., 22. Sept. 2021, 21:09:

…

I'll appreciate if you'll find time to test the latest beta (90100.12-beta) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVWXE23IM7RCFOS7CPRH6HTUDISVDANCNFSM5ELSM6YA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

casualshammy · Answer 9 · 2021-09-24T20:14:32.000Z

Sorry for stupid question, but are you sure you have enabled trinket spells in settings? There are 3: 2 for PvP-Schmuckstück and 1 for Medaillon des Gladiators. I've tested in 2 BGs - looks good to me.
YouTube

piddi19900 · Answer 10 · 2021-09-24T21:09:56.000Z

Hey, I talk about TBC. Am Fr., 24. Sept. 2021 um 22:14 Uhr schrieb casualshammy < ***@***.***>:

…

Sorry for stupid question, but are you sure you have enabled trinket spells in settings. There are 3: 2 for PvP-Schmuckstück and 1 for Medaillon des Gladiators. I've tested 2 BGs - there is not problems to me. YouTube <https://youtu.be/_YDteYpvrGg?t=286> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVWXE25RJVHMND2C7VWN6QTUDTL3FANCNFSM5ELSM6YA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

piddi19900 · Answer 11 · 2021-09-24T21:11:01.000Z

And there is just one field to checkmark. Am Fr., 24. Sept. 2021 um 23:09 Uhr schrieb Pkry ***@***.***>:

…

Hey, I talk about TBC. Am Fr., 24. Sept. 2021 um 22:14 Uhr schrieb casualshammy < ***@***.***>: > Sorry for stupid question, but are you sure you have enabled trinket > spells in settings. There are 3: 2 for PvP-Schmuckstück and 1 for Medaillon > des Gladiators. I've tested 2 BGs - there is not problems to me. > YouTube <https://youtu.be/_YDteYpvrGg?t=286> > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#89 (comment)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AVWXE25RJVHMND2C7VWN6QTUDTL3FANCNFSM5ELSM6YA> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >

piddi19900 · Answer 12 · 2021-09-24T17:59:24.000Z

Trinket still does not work, I have tested it in battleground and in a duel, mhh, any other ideas? :)

casualshammy · Answer 13 · 2021-09-25T11:02:40.000Z

Hey, I talk about TBC.

Ah. As mentioned here I don't have high-level TBC character. I don't know how could I get to locations where players are dueling. So it's impossible for me to get right spell id for trinkets.

piddi19900 · Answer 14 · 2021-09-25T11:17:30.000Z

Ok, if let me know if I can help you 😊 casualshammy ***@***.***> schrieb am Sa., 25. Sept. 2021, 13:02:

…

Hey, I talk about TBC. Ah. As mentioned here <#82 (comment)> I don't have high-level TBC character. I don't know how could I get to locations where players are dueling. So it's impossible to me to get right spell id for trinkets. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVWXE276HXWVAPCUKFGIVE3UDWT5XANCNFSM5ELSM6YA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

piddi19900 · Answer 15 · 2021-10-29T13:39:52.000Z

Hi, It works, thank you for your help, you can close this case. Am Mo., 25. Okt. 2021 um 18:21 Uhr schrieb casualshammy < ***@***.***>:

…

Hi, Will this small issue be corrected soon? :) Thank you. Am I've released version 20501.11-release yesterday, have you tried it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVWXE2ZWLRMY2TYHGSNUKUTUIV72NANCNFSM5ELSM6YA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Leffal · Answer 16 · 2021-10-15T17:12:27.000Z

Hey, I talk about TBC.

Ah. As mentioned here I don't have high-level TBC character. I don't know how could I get to locations where players are dueling. So it's impossible for me to get right spell id for trinkets.

You must use this.

UNIT_SPELLCAST_SUCCEEDED

It doesn't work in CLEU for some reason on TBC.

pvp trinket. Spelled is 42292

casualshammy · Answer 17 · 2021-10-16T13:19:37.000Z

You must use this.

UNIT_SPELLCAST_SUCCEEDED

It doesn't work in CLEU for some reason on TBC.

pvp trinket. Spelled is 42292

Thank you for detailed report. I'll push fix tomorrow.

piddi19900 · Answer 18 · 2021-10-17T20:28:38.000Z

Hey, I have tested it, it shows the trinket cooldown now, great thank you. However the cooldown indication picture is not the official pvp trinket picture, it's another one :) Am Sa., 16. Okt. 2021 um 15:19 Uhr schrieb casualshammy < ***@***.***>:

…

You must use this. UNIT_SPELLCAST_SUCCEEDED It doesn't work in CLEU for some reason on TBC. pvp trinket. Spelled is 42292 Thank you for detailed report. I'll push fix tomorrow. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVWXE24SB7R526FVRUA2RLTUHF3XJANCNFSM5ELSM6YA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Leffal · Answer 19 · 2021-10-19T00:18:40.000Z

Hey, I have tested it, it shows the trinket cooldown now, great thank you. However the cooldown indication picture is not the official pvp trinket picture, it's another one :) Am Sa., 16. Okt. 2021 um 15:19 Uhr schrieb casualshammy < @.***>:
…
You must use this. UNIT_SPELLCAST_SUCCEEDED It doesn't work in CLEU for some reason on TBC. pvp trinket. Spelled is 42292 Thank you for detailed report. I'll push fix tomorrow. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVWXE24SB7R526FVRUA2RLTUHF3XJANCNFSM5ELSM6YA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

when spellid is 42292, change icon id to 133452.

same is true of spell check list

piddi19900 · Answer 20 · 2021-10-25T12:06:30.000Z

Hi, Will this small issue be corrected soon? :) Thank you. Am Di., 19. Okt. 2021 um 02:18 Uhr schrieb Leffal ***@***.***

…

: Hey, I have tested it, it shows the trinket cooldown now, great thank you. However the cooldown indication picture is not the official pvp trinket picture, it's another one :) Am Sa., 16. Okt. 2021 um 15:19 Uhr schrieb casualshammy < *@*.***>: … <#m_311004370937628837_> You must use this. UNIT_SPELLCAST_SUCCEEDED It doesn't work in CLEU for some reason on TBC. pvp trinket. Spelled is 42292 Thank you for detailed report. I'll push fix tomorrow. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment) <#89 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AVWXE24SB7R526FVRUA2RLTUHF3XJANCNFSM5ELSM6YA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub . when spellid is 42292, change icon id to 133452. same is true of spell check list — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#89 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVWXE24IT37QZ3TZI6VYQF3UHS2OXANCNFSM5ELSM6YA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

casualshammy · Answer 21 · 2021-10-25T16:21:46.000Z

Hi, Will this small issue be corrected soon? :) Thank you. Am

I've released version 20501.11-release yesterday, have you tried it?

Share to