Neat Minimap

Neat Minimap

266k Downloads

track down handynotes folks

mooreatv opened this issue ยท 3 comments

commented

ask them to re-parent their notes so there are fewer direct children of Minimap
(like Questie kindly did)

note: we should also probably filter non buttons (assuming those notes are not buttons)

commented

well they are being their usual unreasonable, stubborn and unresponsive... never mind getting collaboration then

we can probably reparent all those addons that use a pattern xxxN and offer the option to hide/show their pins, possibly through keybinds

MooreaTvToday at 3:37 PM
nev, are you open to (or taking PRs) to change handynotes to not have all the pins directly as children of Minimap but inserting a parent frame for these?
  
NevcairielToday at 3:39 PM
There is dozens of addons  adding such pins to the minimap, trying to modify them all isntead of finding a better addon solution seems rather futile
 
MooreaTvToday at 3:42 PM
it works it's just unnecessarily cumbersome to go over a bunch of children, I think it's reasonable code health to attach your frames not directly as children of X when you make a lot of them, no? also I think a lot of those minimap stuff copy from one or the other so if I can convince the big ones, it'll get neater eventually for everyone
 
NevcairielToday at 3:44 PM
I really don't see how its "neater"
it makes no difference to the game
If anything it feels a bit dirty to me to create some pointless empty  unnamed parent frame thats not really good for anything
 
MooreaTvToday at 3:49 PM
it should be named "HandyNotesPins" or some such... for instance imagine there are 2 addons putting notes/pins, A and B and the user wants to be able to switch to see As vs Bs (maybe because some info is duplicate or it gets cluttered) - it'd be a lot easier and natural to do that with AsParentPinFrame:Hide/Show then having to use a pattern search, no?
 
NevcairielToday at 3:49 PM
I would not expect any user to mess with any frames directly, just hit the button for addon A or B to just h ide their pins
 
MooreaTvToday at 3:50 PM
obviously not the user... but even for a single addon... never get the request that some modifier should toggle the pins all at once?
 
NevcairielToday at 3:51 PM
Personally, I discourage and despise any ideas of another addon even thinking about messing with frames created by my addon,  its the prime source of unreproducible and annoying bug reports
commented

we can probably do something with https://github.com/Nevcairiel/HereBeDragons/

commented

found a generic way to skip ^ in next commit