Neuron

Neuron

98.2k Downloads

Pet battle interface issue

Keshk1 opened this issue ยท 9 comments

commented

When I started doing pet battles recently, the menu bar items showed up in the interface. With the menu bar changes, something in Neuron is blocking this from happening. I tried it with all my pet battle addons disabled and it still occurred so I disabled Neuron too and it reappeared in the interface.

no pet addons neuron off
no pet addons neuron on

Hoping the screenshots work correctly.

commented

Yeah the pet battle interface was stealing the buttons away from Neuron, so if there is a Neuron Menu Bar created, I stop the pet battle interface from using the menu bar. Is this a problem for you? Can you explain more about what the issue is?

commented

I like to be able to pull up the "Collections" panel when I am battling wild pets if a rare pops up to see if I have that breed or level. I might be able to figure out how to do the same thing via one of the pet addons.

commented

Oops, wrong button.

commented

Where is your normal menu bar? All of those buttons exist on the normal Neuron Menu Bar, but I don't see it in your screenshot

commented

During pet battles, the normal UI is closed. The menu bar is on the right side of the pet interface "box" in the picture with no addons at all. That box is empty with Neuron on. That is probably why it "steals" the buttons because the pet battle interface is actually a separate UI and pulls the buttons from the standard UI. Just guessing here. If that is true, then there must be a line in the standard UI lua somewhere that recreates them after the battle maybe? As is, the Neuron menu bar is still on the standard UI when a battle ends probably because it wasn't "stolen" at the beginning.

commented

oooh I see now. Yes, you're right. This may be tricky

commented

No rush on it, just wanted you to be aware more than anything. BTW, thanks for all the hard work and keeping this going. Every time it looked like this died, my heart sank because it is the only bar addon that has ever really worked for me.

commented

Ugh I looked at this for the past hour, and I honestly don't know what to do. I can probably figure something out so that the Neuron Menu Bar doesn't hide with the rest of the UI. This is already pretty messy though. There's just no way right now that I can release all the buttons back to blizzard cleanly.

The stupid thing is that the blizzard default code assumes that all the menu buttons are anchored to eachother, thus when they move for the pet battle interface it only actually moves the first button in each of the new rows. However, since our buttons aren't anchored to eachother but rather to the center of the invisible Neuron wrapper buttons, the only buttons that move over are the Character Button and the LFD Button...ugh!

commented

Ok this is fixed now. I intercepted the call that pulls the buttons back in to the pet battle frame, and on the fly we now overwrite this function to put the buttons back on top of the pet battle frame manually. Enjoy!