Neuron

Neuron

98.2k Downloads

Talent only abilities not updating and become unusable

wowregistering opened this issue ยท 15 comments

commented

Prior to the most recent patch if you bound a key to a talent only ability, something like Death from Above or Marked for Death on a rogue, the ability change to a red '?' when untalented and change back to the proper icon when you retalent the ability.

After the recent update, if you follow the below you can replicate the issue easily.

  1. Select a Talent only ability in your Talent window
  2. Drag the Ability to your bars, it will show the icon properly and function in combat
  3. Untalent the ability, the icon will now stay the icon for the untalented ability, before the update it would turn into a red '?'
  4. Retalent the ability, the icon will still have the icon of the ability that you just talented, untalented and retalented.

This causes confusion in the middle of combat, it makes you second guess what talents you have selected. Every time you look at your bars you will see the icon for the ability you untalented being displayed as if you can currently use it.

This may be related to the other bug report I just made, the one about #showtooltip not changing the icon of buttons on the bar anymore.

commented

Thinking about it more, I should probably not have reported this as a bug.

When it 'fades out' the icon with the talent not selected it is actually behaving the same way as the default Blizzard interface, I was just used to Neuron bars turning it into a red '?' instead of greying it out.

commented

present with 0.9.38c and 0.9.38d

The difference between 38c and 38d is the icons now show as a dimmed out version, you can tell that they are not available but it is not clear if that is because they are not talented or because of a prerequisite to casting, ex: needing to be in stealth to use cold blood.

commented

Hrm yeah, I'll have to think on that. Right now we basically just call a function that determines if the ability can be cast at the given time, and if it returns no webgray it out. But like you said that can be due to multiple reasons. Maybe I can split it up to make logical sense

commented

Yeah the turning red is mostly for "out of range" indication. I'm going to mark this as an enhancement for now. I'd like to overhaul how we deal with talented abilities going forward though. I'd like to add some sort of indicator that the ability isn't talented. Perhaps a red overlay "/" or something of the sort.

commented

Yes the error that you listed above means that your profile cannot be migrated successfully to the 1.x spec. Some unfortunately had issues with the migration do to an unknown reason (usually old profiles).

In this scenario you unfortunately have 2 options, reset your profile for 1.x or stick to 0.9.x until you have a chance to reset the profile.

commented

Ah, that is unfortunate. I had just done a few of my profiles yeserday on new 120s and they all broke as well.
I will try to get around to redoing all of those today and then check if the icon behavior has changed at all.

Edit: This is a good chance for me to fix the horrible layout I had ended up with and did not want to put in the effort to fix. >.>'

commented

I think I fixed this, can you confirm? For me, when I put Flourish on my bar and toggle the talent into it back and forth the ability goes grey as it should when I'm talented out of the ability

commented

I updated the addon to 1.0.2c to check but the addon does not function at all currently.

Message: Interface\AddOns\Neuron\Utilities/DB-Fixer.lua:136: bad argument #1 to 'ipairs' (table expected, got nil)
Time: Mon Dec 31 05:28:21 2018
Count: 1
Stack: Interface\AddOns\Neuron\Utilities/DB-Fixer.lua:136: bad argument #1 to 'ipairs' (table expected, got nil)
[C]: in function ipairs' Interface\AddOns\Neuron\Utilities/DB-Fixer.lua:136: in function DBFixer'
Interface\AddOns\Neuron\Neuron.lua:167: in function <Interface\AddOns\Neuron\Neuron.lua:142>
(tail call): ?
[C]: ?
[string "safecall Dispatcher[1]"]:9: in function <[string "safecall Dispatcher[1]"]:5>
(tail call): ?
...ace\AddOns\Neuron\Libs\AceAddon-3.0\AceAddon-3.0.lua:529: in function `InitializeAddon'
...ace\AddOns\Neuron\Libs\AceAddon-3.0\AceAddon-3.0.lua:644: in function <...ace\AddOns\Neuron\Libs\AceAddon-3.0\AceAddon-3.0.lua:636>

Locals:

commented

Also, it would seem you may have misinterpreted what I was talking about with the red buttons in my prior posts, I am talking about the button turning into a black background with a red question mark, not the red 'distance' color change.

I worded what I was trying to say pretty badly, if the buttons do grey out now instead of turning into red question marks or staying fully lit then they would be working the same way as the Blizzard bars.

http://1.bp.blogspot.com/-0bEZjGFAwp8/UFiOu9O2TTI/AAAAAAAAAE0/6IDrulAO_Aw/s1600/WoWScrnShot_091812_170517.jpg

The question mark icons in this random googled screenshot are the ones I was talking about.

commented

Sorry for putting so many replies in separate posts, I had to roll back the version of my addon to 0.9.339g.
https://wow.curseforge.com/projects/neuron/files/2649222

Using 1.0.0, 1.0.1, or 1.0.2c all gave me the error I posted above. I made sure to disable all other addons before checking the current version and the older ones.

Short clip, the bars would be displayed at the bottom if working.
https://gfycat.com/FarawayAlienatedAmericangoldfinch

commented

I set up my bars on my rogue and tried with both PvP and PvE Talent abilites, both seem to work properly now and fade out when untalented.

This also seems to have fixed the issue of untalented abilities turning into red question marks when first logging in or having not talented that ability since logging in.

A new issue I seem to be experiencing now with this update is the 'range' check seems to be very delayed now, sometimes up to 4 seconds to register that I am in range of something.

commented

Can you open up the range check as it's own issue please? If you don't mind just copying and pasting what you have here in a new issue so I can track it easier.

commented

I have deleted the range post and opened it in a new ticket, below is more information related to this ticket.

Just started on my Druid and already have noticed issues with PvP talents.

If I spec into Cyclone and drag it to my bar it just displays a red question mark as the icon, the same for Thorns.

After messing around with this issue more, it appears to not be an issue with Druid, it seems like you have to have the ability available for use at least once before it will display the icon properly.

Steps Followed to reproduce
1: Fresh Profile with Warmode off
2: Talent into Cyclone and drag to bar, it will display as a question mark
After this step even if you log in and out it will not make the icon appear.

3: Turn War mode on, the icon will now appear.
After step 3 the icon will continue to display properly even if you untalent the ability or turn war mode off, continues functioning after relogs.

commented

Yeah that's unavoidable sadly. I can't query the icon until the ability is physically available at least once. That's just a game limitation. If I query the icon and the ability isn't available it comes back as nil. good news is that once the ability is cached, it's cached in memory indefinitely. So it's just that very first time

commented

I'm going to close this issue as it's getting a bit long, and I'm not sure the original issue still exists.

Please open a new ticket I'd you have further tweaks you want made