Neuron

Neuron

98.2k Downloads

Spells when added aren't reflecting the case of the original spells

raysmith59 opened this issue ยท 7 comments

commented

(OCD FTL... low priority)

Spells when dragged to the bar are all lower case rather than reflecting the original case of the spells (mixed upper/lower) as used to happen.

commented

In the name or in the macro itself?

commented

Yeah, I'm mostly just worried that at some point Blizzard will bring in case-sensitivity because that's one of the few things they haven't done to screw me up this expansion. So many bugs and bad changes...

Probably doesn't matter.

commented

Macro detail itself. I really should include more screenshots.

image

commented

Yeah this was done mostly for uniformity in spell lookups. When saving spells to our spellcache we automatically put them all lowercase, we also put whatever macro is written by the user or autowritten lowercase during the lookup as well, that way no matter how many crazy capitalizations a person does, the right spell will always be found (you just have to spell it right). Unfortunately, this leads to it being lowercase when dragged to the bar. I could probably change this and still keep the uniform check working

commented

Good first issue flag? :)

commented

haha yeah it's a good one for people wanting to get their feet wet at programming, because it's pretty small to fix. I actually already fixed it though lol. If you're not seeing it, you need to try re-dragging an ability. Unfortunately I can't retroactively rewrite the already written macros

commented

Hah! Never realized that's what it meant, I always took it as a pat on the head for the bug reporter to encourage them to keep doing it. :)