[NeuronNext] Hidden bag and system bars are not hidden
AlexFolland opened this issue ยท 6 comments
To reproduce:
- Switch to NeuronNext branch and run the game
- Enter bar edit mode
- Set the bag and system bars to hidden
- Exit bar edit mode
Current behavior:
Bag and system bars marked "hidden" are visible outside of bar edit mode.
Expected behavior:
Bars marked "hidden" are expected to be invisible outside of bar edit mode.
is this still an issue with current neuronnext @AlexFolland ?
Whoops looks like a holdover from our object rename happened. It should be "MICRO_BUTTONS" not "MICRO_ButtonS". Can you fix that @ylixir?
I tried to switch to NeuronNext to test this in Wrath Classic, which is what I am playing, but my bars were not present and I was hit with errors. I could see a "menu bar" in Neuron, but there was no menu in it, even though the bar's "hidden" setting was disabled. Here are the errors:
1x Neuron\Objects\MenuButton.lua:16: attempt to get length of global 'MICRO_ButtonS' (a nil value)
[string "@Neuron\Objects\MenuButton.lua"]:16: in main chunk
Locals:
_ = "Neuron"
addonTable = <table> {
utilities = <table> {
}
databaseDefaults = <table> {
}
Neuron = <unnamed> {
}
}
Neuron = <unnamed> {
0 = <userdata>
SetDefaultModuleLibraries = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:367
ToggleButtonEditMode = <function> defined @Neuron\Neuron.lua:484
LoginMessage = <function> defined @Neuron\Neuron.lua:268
EnableModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:332
modules = <table> {
}
CancelTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:147
IterateEmbeds = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:442
SecureHookScript = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:410
CreateNewBar = <function> defined @Neuron\Objects\Bar.lua:168
UpdateSpellCache = <function> defined @Neuron\Neuron.lua:325
itemCache = <table> {
}
RawHookScript = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:395
Printf = <function> defined @Ace3\AceConsole-3.0\AceConsole-3.0.lua:69
FOBtnIndex = <table> {
}
SetDefaultModulePrototype = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:409
STRATAS = <table> {
}
defaultModuleState = true
IsEnabled = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:451
ScheduleTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:94
DisableModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:350
isWoWWrathClassic = true
SPELLS_CHANGED = <function> defined @Neuron\Neuron.lua:216
RegisterMessage = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
GetArgs = <function> defined @Ace3\AceConsole-3.0\AceConsole-3.0.lua:144
spellCache = <table> {
}
ExitButton = <table> {
}
hooks = <table> {
}
ToggleMainMenu = <function> defined @Neuron\Neuron.lua:449
Button = <table> {
}
SetEnabledState = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:424
Hook = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:274
enabledState = true
RegisterEvent = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
GetSerializedAndCompressedProfile = <function> defined @Neuron\Neuron.lua:592
IterateModules = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:437
isWoWClassicEra = false
RawHook = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:313
CHARACTER_POINTS_CHANGED = <function> defined @Neuron\Neuron.lua:211
TIMERLIMIT = 4
Bar = <table> {
}
SNAPTO_TOLERANCE = 28
MenuButton = <table> {
}
IsHooked = <function> defined @Ace3\AceHook-3.0\AceHook-3.0.lua:493
Enable = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:294
UnregisterAllEvents = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
SetSpellInfo = <function> defined @Neuron\Neuron.lua:301
BagButton = <table> {
}
AnchorIndex = <table> {
}
GetModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:210
FOBarIndex = <table> {
}
ActionButton = <table> {
}
DBFixer = <function> defined @Neuron\Utilities\DB-Fixer.lua:13
registeredBarData = <table> {
}
TimeLeft = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:172
Deserialize = <function> defined @Ace3\AceSerializer-3.0\AceSerializer-3.0.lua:246
UnregisterChatCommand = <function> defined @Ace3\AceConsole-3.0\AceConsole-3.0.lua:111
defaultModuleLibraries = <table> {
}
ScheduleRepeatingTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:129
CancelAllTimers = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:16
1x Neuron\Objects\Button.lua:32: attempt to concatenate local 'objType' (a nil value)
[string "@Neuron\Objects\Button.lua"]:32: in function `new'
[string "@Neuron\Neuron-Startup.lua"]:249: in function `CreateBarsAndButtons'
[string "@Neuron\Neuron-Startup.lua"]:17: in function `Startup'
[string "@Neuron\Neuron-@[email protected]"]:99: in function <Neuron\Neuron.lua:63>
[string "=[C]"]: ?
[string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:498: in function `InitializeAddon'
[string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:623: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:615>
#461 should fix your lua errors @AlexFolland
Yes, that fixed it, and my bars are all present in-game. However, the issue originally reported is not resolved. No bar becomes hidden when the "hidden" option is enabled for that bar, including the menu bar.