No Mats; No Make

No Mats; No Make

258k Downloads

Hide listings checkbox not working, throws LUA error

hollo6 opened this issue ยท 3 comments

commented

Trying to hide no-mats listings, ticking the checkbox and then clicking Search again throws the following LUA error (and all the listings remain shown):

2x ...cOrdersReagentsColumn/PublicOrdersReagentsColumn.lua:30: attempt to compare number with nil
[string "@PublicOrdersReagentsColumn/PublicOrdersReagentsColumn.lua"]:30: in function recursion' [string "@PublicOrdersReagentsColumn/PublicOrdersReagentsColumn.lua"]:38: in function <...cOrdersReagentsColumn/PublicOrdersReagentsColumn.lua:19> [string "=[C]"]: ? [string "=[C]"]: in function ShowGeneric'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:743: in function ShowOrders' [string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:756: in function OrderRequestCallback'
[string "@Blizzard_Professions/Blizzard_ProfessionsCrafterOrderPage.lua"]:642: in function <...Professions/Blizzard_ProfessionsCrafterOrderPage.lua:642>

Locals:
collection =

{
1 =
{
}
2 =
{
}
3 =
{
}
4 =
{
}
5 =
{
}
6 =
{
}
}
(for index) = 1
(for limit) = 6
(for step) = 1
i = 1
(*temporary) = 200
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to compare number with nil"
dataProvider =
{
InsertTableRange = defined @SharedXML/DataProvider.lua:66
InsertInternal = defined @SharedXML/DataProvider.lua:42
collection =
{
}
ReverseEnumerate = defined @SharedXML/DataProvider.lua:26
FindElementDataByPredicate = defined @SharedXML/DataProvider.lua:172
GetSize = defined @SharedXML/DataProvider.lua:34
GenerateCallbackEvents = defined @SharedXML/CallbackRegistry.lua:181
DoesFrameHaveEvent = defined @SharedXML/CallbackRegistry.lua:194
callbackTables =
{
}
Flush = defined @SharedXML/DataProvider.lua:199
RegisterCallback = defined @SharedXML/CallbackRegistry.lua:75
RemoveByPredicate = defined @SharedXML/DataProvider.lua:104
SetUndefinedEventsAllowed = defined @SharedXML/CallbackRegistry.lua:42
UnregisterCallback = defined @SharedXML/CallbackRegistry.lua:150
RegisterCallbackWithHandle = defined @SharedXML/CallbackRegistry.lua:119
FindByPredicate = defined @SharedXML/DataProvider.lua:164
HasSortComparator = defined @SharedXML/DataProvider.lua:141
GetCallbackTables = defined @SharedXML/CallbackRegistry.lua:46
GetCallbacksByEvent = defined @SharedXML/CallbackRegistry.lua:54
SecureInsertEvent = defined @SharedXML/CallbackRegistry.lua:69
Remove = defined @SharedXML/DataProvider.lua:81
RemoveIndexRange = defined @SharedXML/DataProvider.lua:115
Enumerate = defined @SharedXML/DataProvider.lua:22
OnLoad = defined @SharedXML/CallbackRegistry.lua:34
TriggerEvent = defined @SharedXML/CallbackRegistry.lua:124
SetSortComparator = defined @SharedXML/DataProvider.lua:134
Insert = defined @SharedXML/DataProvider.lua:48
UnregisterEvents = defined @SharedXML/CallbackRegistry.lua:165
InsertTable = defined @SharedXML/DataProvider.lua:62
Init = defined @SharedXML/DataProvider.lua:12
GetCallbackTable = defined @SharedXML/CallbackRegistry.lua:50
ReverseForEach = defined @SharedXML/DataProvider.lua:193
IsEmpty = defined @SharedXML/DataProvider.lua:38
Find = defined @SharedXML/DataProvider.lua:152
HasRegistrantsForEvent = defined @SharedXML/CallbackRegistry.lua:59
RemoveIndex = defined @SharedXML/DataProvider.lua:111
Event =
{
}
ContainsByPredicate = defined @SharedXML/DataProvider.lua:182
GetCollection = defined @SharedXML/DataProvider.lua:30
FindIndex = defined @SharedXML/DataProvider.lua:156
Sort = defined @SharedXML/DataProvider.lua:145
ForEach = defined @SharedXML/DataProvider.lua:187
FindIndexByPredicate = defined @SharedXML/DataProvider.lua:177
}

commented

Here you go; this is only one of them, it behaves the same for other professions too.
image

commented

Can you give me a screenshot of the crafting orders? It looks like there is an order that doesn't have a commission - which I didn't know was possible.

commented

Thanks, found the problem. Patch going up soon.

In the meantime, as a workaround just move the slider. Then move it back to 0 again if you want.
image