OmniCC

OmniCC

58M Downloads

Incorrect Cooldown/Numbers Showing

AlexTighe opened this issue · 7 comments

commented

Using 8.0.2 Beta 2

Incorrect numbers are appearing on buff frames for buffs that should have no timer on them.
It seems to normally be that when it happens it is using the same duration as a duration next to it.

A reload will fix the issue.

commented

Can you try again with beta3?

commented

Looking at the code for Shadowed

-- Show the cooldown ring
if( not ShadowUF.db.profile.auras.disableCooldown and duration > 0 and endTime > 0 and ( config.timers.ALL or ( category == "player" and config.timers.SELF ) or ( category == "boss" and config.timers.BOSS ) ) ) then
	button.cooldown:SetCooldown(endTime - duration, duration)
	button.cooldown:Show()
else
	button.cooldown:Hide()
end

They're hiding cooldowns, but not actually clearing them, So I probably just need to adjust OmniCC to clear on hide

commented

I've had a better look with a fresh set of eyes today, and it seems to be an interaction with Shadowed Unit Frames, as it work's with the default blizzard frames, so not sure how much this applies still I guess.

I'll detail the Shadowed Unit Frames/OmniCC issue though, I don't know which addon is "to blame". Maybe you'll have a better idea!

If I have a target with their 3rd buff being a duration of 12 seconds, then target someone else, who then has a 3rd buff with no duration OmniCC will use the duration of the previous target's 3rd buff and show a timer where there shouldn't be.

Bug

  • Realgirl's 3rd buff has no duration.
  • Targeting Taylorswift, who's 3rd buff has a duration (As it should)
  • Target Realgirl again, who's 3rd buff now shows a duration the same as Taylorswift's despite the buff having no duration
commented

Could this also cause the following problem on the icons of Hekili (a rotation/priority helper addon)?
When I use an ability Hekili switches the icon to the next ability to use. But if this next ability doesn't have a cooldown (only the GCD) OmniCC 8.0.2-Beta3 actually shows the cooldown number of the ability that I just used (that was just cleared from the icon).

If this is something else I can also create a separate issue.

commented

Yes, it’s likely the same issue

commented

It should be fixed in beta4.

commented

Yeah, seems to be fixed for Shadowed Unit Frames at least, can't say for Hekili as I don't use it.