Fel rush first stack
zorixx opened this issue ยท 4 comments
Hello, since the 8.0.3 my first charge of fel rush is considered as a normal CD and not as a restoring charge.
So that is because I changed the code that determines if something is a charge or not. This is what it looks like in the current versions of timer.lua
local function cooldown_GetKind(cooldown)
if cooldown.currentCooldownType == COOLDOWN_TYPE_LOSS_OF_CONTROL then
return "loc"
end
local parent = cooldown:GetParent()
if parent and parent.chargeCooldown == cooldown then
return "charge"
end
return "default"
end
This is what it would look like if you changed it to be closer to how 8.0.1 does the check:
local function cooldown_GetKind(cooldown)
if cooldown.currentCooldownType == COOLDOWN_TYPE_LOSS_OF_CONTROL then
return "loc"
end
-- 8.0.1 and earlier behavior for charge cooldown detection
if not cooldown:GetDrawSwipe() then
return "charge"
end
return "default"
end
I changed from not cooldown:GetDrawSwipe()
because that check is a guess based off of how a cooldown looks and not what it is intended to be. The parent.chargeCooldown == cooldown
check is more indicative of that, and works with pretty much all action bar addons.