"Finish Effect" does not fire when recharge-abilities go from 0 to 1 charges
Arcitec opened this issue ยท 3 comments
According to #105, the intended behavior is "finish effect should only fire when the recharging spell becomes available". Which I interpret to mean that when a fully-used recharging spell becomes available again, it SHOULD trigger the "finish effect". But it doesn't...
So, try being a demon hunter and use both charges of fel rush (so that you now have zero charges left). The cooldown text style on the button changes to the "primary" style (rather than the "recharging" style) to indicate that no charges remain.
But, when a charge is gained (meaning it goes from zero to ONE charge) there is NO "finish" effect on the icon.
Nor is there any "finish" effect when the charges max out...
That is really painful since it makes it hard to know when spells that have charges (and that you used all charges for) become available again.
I am assuming that the ping is broken right now and was intended to show somewhere when a recharging spell becomes available again... The most useful feature for me would be that it "pings" (finish-effect) when it goes from 0 to 1 charge (which is how I interpreted the actual intentions of the addon too, in the ticket above). Other people may want a ping when it goes to "max charges". So a GUI option to choose behavior would probably be necessary too, with options for "Play finish effect for recharging abilities: 1. Never, 2. On first charge becoming available, 3. On full charges becoming available, 4. On every charge."
PS: I have set "Minimum duration to display a finish effect: 2 seconds", and the effect to Pulse.
The latest beta should fix this
https://github.com/tullamods/OmniCC/releases/tag/9.0.0-beta
With version 9.0.1, for me the finish effect does not play when the cooldown ends, but rather when the cooldown starts
I'm talking about regular (non-recharge) abilities...
With version 9.0.1, for me the finish effect does not play when the cooldown ends, but rather when the cooldown starts
I'm talking about regular (non-recharge) abilities...
The same is happening to me. I did a fresh install (deleted .wtf files) and strangely OmniCC is behaving correctly on my actionbars but not on my Weakauras.
Version: 9.0.1
Tested with all addons disabled other than OmniCC and WeakAuras