Ion + OmniCC
Addonman opened this issue ยท 19 comments
yes
to be sure i double checked it-settings look fine-enable cooldown text is thicked
100%.but i tested with 0% as well-i couldnt see numbers at all no matter what setting it was
I found that the problem is caused by the moving of the timer code inside of "function Cooldown:Start(...)" cooldown.lua (line 12). I suspect it's because the timer is being setup before the cooldown is setup.
Changing that function to the following fixes this for me.
function Cooldown:Start(...)
if Cooldown.CanShow(self, ...) then
Cooldown.Setup(self)
local timer = Timer:Get(self) or Timer:New(self)
timer:UpdateOpacity()
timer:Start(...)
else
Cooldown.Stop(self)
end
end
I've been trying OmniCC with Ion, and I don't know what I can tell you. It works fine.
With that fix works normally,but without it didn't-at least for me-will try next version to see if that will fix it
Confirming that without the fix, Omnicc doesn't function with Ion.
However, with the fix, no issues at all.
I am not sure the exact reason why it fails when using Ion but just by looking at the current non-working code (for Ion users), a Timer gets created which uses the cooldown object to initialize stuff (see lines 26 to 34 in timer.lua). However, the cooldown object is not setup yet. "Cooldown.Setup(self)" gets called after the Timer gets created. This would seem to be an error in programming. In previous versions of the code, the cooldown is setup first before creating the timer and that code works.
I can confirm that OmniCC isn't working for Ion. I haven't tried the fix yet. Although it's a bit more subtle than that. It does work for some buttons, but not for most of them. I'm not sure why yet. But, for example, my Fortifying Brew shows an OmniCC cooldown, but almost nothing else on my bars does.
And now after applying the fix I can confirm that all Ion buttons now show OmniCC cooldowns properly.
Well, if OmniCC doesn't work with Ion, then it doesn't matter what features it has, it's not very useful for me (and for any other Ion user). So could you please explain what's wrong with this change? Or better yet, why OmniCC as it exists today isn't compatible with Ion?
Jaliborc, would you mind briefly explaining what other features are broken if the patch I posted is used?