Seems it's not compatible with pitbull unitframe 4.0 now
hobulian opened this issue · 6 comments
I got those:
25x PitBull4\Modules\Aura\Filter-Filter.lua:15: attempt to index field 'db' (a nil value) [string "@PitBull4\Modules\Aura\Filter-Filter.lua"]:15: in function GetFilterDB'
[string "@pitbull4\Modules\Aura\Filter-Filter.lua"]:96: in function PLAYER_TALENT_UPDATE' [string "@PitBull4\Modules\Aura\Aura.lua"]:49: in function <PitBull4\Modules\Aura\Aura.lua:38> [string "=[C]"]: ? [string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:65> [string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:527: in function EnableAddon'
[string "@ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:540: in function EnableAddon' [string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:630: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:615>
8x PitBull4\Modules\Aura\Skin.lua:29: attempt to index field 'db' (a nil value)
[string "@PitBull4\Modules\Aura\Skin.lua"]:29: in function `?'
[string "@PitBull4\Modules\Aura\Aura.lua"]:61: in function `OnProfileChanged'
[string "@PitBull4\Main.lua"]:1512: in function `OnProfileChanged'
[string "@PitBull4\Main.lua"]:1645: in function <PitBull4\Main.lua:1615>
[string "=[C]"]: ?
[string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:70: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:65>
[string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:527: in function `EnableAddon'
[string "@Ace3\AceAddon-3.0\AceAddon-3.0-13.lua"]:630: in function <Ace3\AceAddon-3.0\AceAddon-3.0.lua:615>
8x PitBull4\Modules\Aura\Options-Optionen.lua:552: attempt to index local 'self_buffs' (a nil value)
[string "@PitBull4\Modules\Aura\Options-Optionen.lua"]:552: in main chunk
Locals:
PitBull4 = <table> {
IterateFramesForName = <function> defined @PitBull4\Main.lua:921
GroupHeader__scripts = <table> {
}
IterateHeadersForSuperUnitGroup = <function> defined @PitBull4\Main.lua:971
IterateEnabledModules = <function> defined @PitBull4\ModuleHandling\Module.lua:428
modules = <table> {
}
CancelTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:147
OnNewProfile = <function> defined @PitBull4\Main.lua:1594
OnTanksUpdated = <function> defined @PitBull4\Main.lua:1045
MakeSingletonFrame = <function> defined @PitBull4\Main.lua:549
defaultModulePrototype = <table> {
}
Aggro = <table> {
}
modules_not_loaded = <table> {
}
PLAYER_REGEN_DISABLED = <function> defined @PitBull4\Main.lua:1958
OnProfileReset = <function> defined @PitBull4\Main.lua:1598
SINGLETON_CLASSIFICATIONS = <table> {
}
singleton_frames = <table> {
}
IsEnabled = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:451
ScheduleTimer = <function> defined @Ace3\AceTimer-3.0\AceTimer-3.0.lua:94
unit_group_to_headers = <table> {
}
ADDON_LOADED = <function> defined @PitBull4\ModuleHandling\Module.lua:98
IterateLoadOnDemandModules = <function> defined @PitBull4\Main.lua:1347
UnregisterMessage = <function> defined @Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
LoadAndEnableModule = <function> defined @PitBull4\Main.lua:1463
MigrateGroupAnchorToNewFormat = <function> defined @PitBull4\GroupHeader.lua:308
PLAYER_FOCUS_CHANGED = <function> defined @PitBull4\Main.lua:1741
unit_id_to_guid = <table> {
}
IterateFrameScriptHooks = <function> defined @PitBull4\ModuleHandling\Module.lua:56
SetEnabledState = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:424
OnModuleCreated = <function> defined @PitBull4\ModuleHandling\Module.lua:86
ZONE_CHANGED_NEW_AREA = <function> defined @PitBull4\Main.lua:1821
unit_id_to_frames_with_wacky = <table> {
}
OnEnable = <function> defined @PitBull4\Main.lua:1615
AltPowerBar = <table> {
}
unit_id_to_frames = <table> {
}
RunOnLeaveCombat = <function> defined @PitBull4\Main.lua:1974
wacky_frames = <table> {
}
UnitFrame = <table> {
}
super_unit_group_to_headers = <table> {
}
NewModule = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:235
del = <function> defined @PitBull4\Main.lua:389
IterateFrames = <function> defined @PitBull4\Main.lua:607
CheckGUIDForUnitID = <function> defined @PitBull4\Main.lua:1711
IterateHeadersForName = <function> defined @PitBull4\Main.lua:999
UNIT_PET = <function> defined @PitBull4\Main.lua:1760
UNIT_GROUPS = <table> {
}
NewModuleType = <function> defined @PitBull4\ModuleHandling\Module.lua:30
all_frames_list = <table> {
}
Controls = <table> {
}
GetConfigModeValues = <function> defined @PitBull4\Options\ConfigMode.lua:21
OnProfileChanged = <function> defined @PitBull4\Main.lua:1490
IterateFramesForUnitIDs = <function> defined @PitBull4\Main.lua:731
name = "PitBull4"
IterateFramesForUnitID = <function> defined @PitBull4\Main.lua:702
Disable = <function> defined @Ace3\AceAddon-3.0\AceAddon-3.0.lua:314
ConvertIntoUnitFrame = <function> defined @PitBull4\UnitFrame.lua:403
non_wacky_frames = <table> {
}
all_headers = <table> {
}
name_to_header = <table> {
}
L = <table> {
}
PLAYER_TARGET_CHANGED = <function> defined @PitBull4\Main.lua:1747
PLAYER_LEAVING_WORLD = <function> defined @PitBull4\Main.lua:1922
member_frames = <table> {
}
EnableModuleAndSaveState = <function
This commit introduced it f009788
The issue is this line:
Tables in wow lua are copied by reference. So adding an element to the local variable also mutates the global CLASS_SORT_ORDER, which trips pitbull.
changing f009788#diff-a73a407633a76721268d2e02a8145c8fbcc1827d56b4b0579fbf74377f9203deR45-R46 into
local CLASS_SORT_ORDER_WITH_GENERAL = {}
for index, value in pairs(CLASS_SORT_ORDER) do
CLASS_SORT_ORDER_WITH_GENERAL[index] = value
end
CLASS_SORT_ORDER_WITH_GENERAL[0] = "GENERAL"seems to fix it.
I guess LOCALIZED_CLASS_NAMES_MALE should be treated similarly, even though pitbull isn't bothered by that mutation, maybe another addons has side effects.