Consumable check - Vantus Rune Sepulcher of the First Ones

Question

Consumable check - Vantus Rune Sepulcher of the First Ones

fraerie opened this issue 2 years ago · 25 comments

fraerie commented 2 years ago

Describe the problem

What steps will reproduce the problem?

Check Buffs
view Vantus Rune column
status of Sepulcher of the First Ones vasntus rune not displayed

Consider attaching a screenshot below to help describe your issue (Attach directly, do not link to other websites)

What version of the addon are you using? (Stating 'latest' is not useful)

9.2.1 for game version 9.2.5

Do you have an error log of what happened?

Any additional information? (example: WoW language if not English)

fraerie · Answer 1 · 2022-07-20T04:07:35.000Z

If you want to make some pull requests I'll merge them in :p I'll probably take a look at oRA and update stuff sometime later this week

Both Treize and I looked at creating a pull request and chickened out, but have verified the consumables file linked above works and is stable.

TreizeEU · Answer 2 · 2022-07-04T22:28:21.000Z

Hello.

Are there a fix in the works for this? I only noticed it wasn't working today, so I thought if I had missed an update.

While trying to fix this myself, I encountered a weird issue with wowhead having duplicates of spells for each of the bosses in Sepulcher with different spell ID's. I tried to add each boss with one of the ID's and encounter ID's from the below webpage. Any ideas? I hope any of this helps you figure out a fix for this? All I know is that the below code works for The Jailer, but I can't check the rest.

https://wowpedia.fandom.com/wiki/JournalEncounterID

Code I attempted to add to line 64 in file \oRA3\modules\Consumables.lua:

	-- Sepulcher of the First Ones
	[354403] = 2458, -- Guardian of the First Ones
	[367120] = 2465, -- Skolex, the Insatiable Ravener
	[367124] = 2458, -- Artificer Xy'mox
	[367125] = 2459, -- Dausegne, the Fallen Oracle
	[367127] = 2460, -- Prototype Pantheon
	[367129] = 2461, -- Lihuvim, Principal Architect
	[367131] = 2463, -- Halondrus the Reclaimer
	[367133] = 2469, -- Anduin Wrynn
	[367135] = 2457, -- Lords of Dread
	[367139] = 2467, -- Rygelon
	[367143] = 2464, -- The Jailer, Zovaal
}

nebularg · Answer 3 · 2022-07-05T10:25:28.000Z

If you want to make some pull requests I'll merge them in :p I'll probably take a look at oRA and update stuff sometime later this week

fraerie · Answer 4 · 2022-07-05T07:25:58.000Z

As far as I can tell, the two IDs are one that sets the flag that a vantus rune has been used - so you can't use another one that week. The second one is applying the aura which gives the bonus versatility against that boss.

So for Guardian of the First Ones, the vantus rune used flag is spell ID 354403, and the aura is spell ID 354390.

The existing code seems to use the aura applied spell ID.

So for the flag applied ID the code block would be:

-- Sepulcher of the First Ones
	[354403] = 2458, -- Guardian of the First Ones
	[367120] = 2465, -- Skolex, the Insatiable Ravener
	[367123] = 2470, -- Artificer Xy'mox
	[367125] = 2459, -- Dausegne, the Fallen Oracle
	[367127] = 2460, -- Prototype Pantheon
	[367129] = 2461, -- Lihuvim, Principal Architect
	[367131] = 2463, -- Halondrus the Reclaimer
	[367133] = 2469, -- Anduin Wrynn
	[367135] = 2457, -- Lords of Dread
	[367139] = 2467, -- Rygelon
	[367142] = 2464, -- The Jailer, Zovaal
}

So for the aura applied ID the code block would be:

-- Sepulcher of the First Ones
	[354390] = 2458, -- Guardian of the First Ones
	[367121] = 2465, -- Skolex, the Insatiable Ravener
	[367124] = 2470, -- Artificer Xy'mox
	[367126] = 2459, -- Dausegne, the Fallen Oracle
	[367128] = 2460, -- Prototype Pantheon
	[367130] = 2461, -- Lihuvim, Principal Architect
	[367132] = 2463, -- Halondrus the Reclaimer
	[367134] = 2469, -- Anduin Wrynn
	[367136] = 2457, -- Lords of Dread
	[367140] = 2467, -- Rygelon
	[367143] = 2464, -- The Jailer, Zovaal
}

TreizeEU · Answer 5 · 2022-07-05T07:40:17.000Z

Also, I helped fixing issue #108 while I was at it, same file.

TreizeEU · Answer 6 · 2022-07-05T07:37:31.000Z

Hello fraerie.

I've worked out the vantus rune code for the jailer. I took the second number from the JournalEncounterID page I linked, then swapped the first number with the two versions, and landed on it working with 367143 (since I have an active vantus rune for jailer on my main). I'm not sure if it's the same ID (aura as opposed to flag) for all of them?

fraerie · Answer 7 · 2022-07-05T07:41:41.000Z

I've gone through and cross checked the encounter IDs from the link you posted (the encounter ID you had for Artificer was incorrect), and checked the current Vantus rune spell ids from the ORA3 code against the flag vs aura IDs in the WowHead database. I think it's the Aura Applied spell ID.

I've edited my consumables file - I'll let you know if it works this week.

TreizeEU · Answer 8 · 2022-07-05T07:47:46.000Z

Oh yeah, I just noticed I had duped the number for first boss with Artificer. Artificer's second number should be 2470, indeed.

fraerie · Answer 9 · 2022-07-06T06:54:48.000Z

If you want to make some pull requests I'll merge them in :p I'll probably take a look at oRA and update stuff sometime later this week

Um...I'm not a dev so I don't really know what a pull request involves... I'm a BA and can cross check tables of data, but doing pull requests is a bit outside my wheelhouse. :)

TreizeEU · Answer 10 · 2022-07-06T06:56:26.000Z

I put up a pull request for the Eternal Augment Rune. I know that one works. Wasn't sure if I could add both changes (Vantus rune and Augment rune) in the same pull request, and wasn't sure how much of the Vantus rune code actually works.

fraerie · Answer 11 · 2022-07-06T06:58:02.000Z

I may be able to test Jailer or Rygalon this week depending on how progression goes.

TreizeEU · Answer 12 · 2022-07-06T06:58:31.000Z

This is my current Consumables.lua file:

Consumables.zip

TreizeEU · Answer 13 · 2022-07-06T07:16:55.000Z

I didn't create a pull request, I made a fork instead because I don't know what I'm doing. But I think I managed to delete the fork. :x

@fraerie The Vantus rune code for the jailer was working yesterday. The file above has all the changes I've made to it. I don't know how to do a pull request, so I'll just leave the file there for the developer to do something with?

axelkic · Answer 14 · 2022-07-24T02:41:01.000Z

I think we want the ones that have the slider: https://www.wowhead.com/spell=359893/vantus-rune-progenitor-defense-system -- but I think Vigilant Guardian === Progenitor

fraerie · Answer 15 · 2022-07-24T02:20:35.000Z

Re the message I got saying this had already been fixed - I've checked the code for the version currently on the DL link (v9.2.1), it only includes the following runes, it's still missing the SotFO runes.

local getVantus, getVantusBoss
do
	local runes = {
		-- Castle Nathria
		[311445] = 2393, -- Shriekwing
		[311446] = 2428, -- Hungering Destroyer
		[311448] = 2422, -- Sun King's Salvation
		[311447] = 2418, -- Artificer Xy'mox
		[311449] = 2420, -- Lady Inerva Darkvein
		[311450] = 2426, -- The Council of Blood
		[311451] = 2394, -- Sludgefist
		[311452] = 2425, -- Stone Legion Generals
		[334131] = 2424, -- Sire Denathrius
		[334132] = 2429, -- Huntsman Altimor
		-- Sanctum of Domination
		[354384] = 2435, -- The Tarragrue
		[354385] = 2442, -- The Eye of the Jailer
		[354386] = 2439, -- The Nine
		[354387] = 2444, -- Remnant of Ner'zhul
		[354388] = 2445, -- Soulrender Dormazain
		[354389] = 2443, -- Painsmith Raznal
		[354390] = 2446, -- Guardian of the First Ones
		[354391] = 2447, -- Fatescribe Roh-Kalo
		[354392] = 2440, -- Kel'Thuzad
		[354393] = 2441, -- Sylvanas Windrunner
	}

axelkic · Answer 16 · 2022-07-24T02:25:02.000Z

Also, this is invalid:

		-- Sepulcher of the First Ones
		[354390] = 2458, -- Guardian of the First Ones
		[367121] = 2465, -- Skolex, the Insatiable Ravener
		[367124] = 2470, -- Artificer Xy'mox
		[367126] = 2459, -- Dausegne, the Fallen Oracle
		[367128] = 2460, -- Prototype Pantheon
		[367130] = 2461, -- Lihuvim, Principal Architect
		[367132] = 2463, -- Halondrus the Reclaimer
		[367134] = 2469, -- Anduin Wrynn
		[367136] = 2457, -- Lords of Dread
		[367140] = 2467, -- Rygelon
		[367143] = 2464, -- The Jailer, Zovaal

There's already an id of 354390 referring to the SoD Guardian of the First Ones, the first Sepulcher can't have the same id. It should start with 367... like the others

Edit: it should be Vigilant Guardian not Guardian of the First Ones

fraerie · Answer 17 · 2022-07-24T02:45:43.000Z

Checking the attributes I concur on
https://www.wowhead.com/spell=359893/vantus-rune-progenitor-defense-system

But it's the one that isn't aligned with the rest of them for how it's built.

Ultimately I doubt it's terribly relevant at this point with less than two weeks to the end of the season. People don't really use rune on the first boss of a tier.

fraerie · Answer 18 · 2022-07-24T02:28:15.000Z

The encounter ID references came from here:
https://wowpedia.fandom.com/wiki/JournalEncounterID

The vantus run IDs came from wowheads DB.

If you have a better reference for Guardian, great, I couldn't find one. I haven't tested Guardian as we didn't need runes for it. The code fragment above has worked for the last four bosses, being the only ones I've tested it for.

axelkic · Answer 19 · 2022-07-24T02:36:06.000Z

I don't have a better reference, I don't know if you even can vantus rune Vigilant Guardian, but we can't have the overlapping id or the code will fail. Going to just remove Vigilant Guardian from the list.

fraerie · Answer 20 · 2022-07-24T02:37:35.000Z

The Vigilant Guardian rune wasn't created at the same time as the rest of them

https://www.wowhead.com/spells/uncategorized/name:Vantus+Rune:?filter=21:21;2:5;90105:90205

I recall it taking quite a bit of digging to find it. It was created in 9.1.0

https://www.wowhead.com/spells/uncategorized/name:Vantus+Rune:?filter=21:21;2:5;90100:90205

https://www.wowhead.com/spell=354390/vantus-rune-guardian-of-the-first-ones

Unless it's using this one

https://www.wowhead.com/spell=359892/vantus-rune-progenitor-defense-system

axelkic · Answer 21 · 2022-07-24T02:51:17.000Z

Checking the attributes I concur on https://www.wowhead.com/spell=359893/vantus-rune-progenitor-defense-system

But it's the one that isn't aligned with the rest of them for how it's built.

Ultimately I doubt it's terribly relevant at this point with less than two weeks to the end of the season. People don't really use rune on the first boss of a tier.

True, just for completion sake. Going to look into oils next.

TreizeEU · Answer 22 · 2022-07-24T10:15:50.000Z

We might still use vantus runes in Sepulcher in season 4's fated raid difficulty, so it might not be completely irrelevant quite yet?

And I confirm you can use the vantus rune on first boss by using it on the one attackable npc (Vigilant Custodian?) that's patrolling around, so the number "359893" are correct for Vigilant Guardian. I just ran in with my mage while in a raid group for a world boss, ran past trash and invis'ed. The buff does say "Vantus Rune: Progenitor Defense System".

TreizeEU · Answer 23 · 2022-08-19T05:01:45.000Z

I haven't seen anyone update this addon for a while now, so I'm just going to leave this Consumables.lua file here. Which, I believe, fixes this ticket, as well as ticket 108 for the Eternal Augment Rune buff tracking.

Consumables.zip

fraerie · Answer 24 · 2022-09-09T05:04:28.000Z

Note - the updated version of this file has not been included in the 9.2.2 release.

funkydude · Answer 25 · 2022-09-10T17:29:07.000Z

Note - the updated version of this file has not been included in the 9.2.2 release.

I merged the #112 pull request, thanks!

Share to

Describe the problem

What steps will reproduce the problem?

Consider attaching a screenshot below to help describe your issue (Attach directly, do not link to other websites)

What version of the addon are you using? (Stating 'latest' is not useful)

Do you have an error log of what happened?

Any additional information? (example: WoW language if not English)