oUF_Phanx

oUF_Phanx

35.8k Downloads

Show value instead of percent for non-mana power

Pingumania opened this issue ยท 3 comments

commented

The rage text shows a wrong number. (Maybe on other classes too, I play only warrior atm)

In the screenshot I have 18 rage points according to oUF_Phanx and 20 according to nPower.
My skill on hotkey 4 needs 20 or more and I am able to cast it. So nPower shows the wright number.

wowscrnshot_090116_001801

commented

Not sure what to tell you. oUF_Phanx just queries the standard UnitPower API function, and displays whatever number the game client returns. If you notice such a discrepancy again, run this command and report back with what it says in your chat frame:

/dump UnitPower("player")

Other than that, this could happen if something was causing an actual error (thus preventing the update function from completing) but I see a green BugSack icon in your screenshot (no errors) so that isn't happening here.

commented

/dump UnitPower("player") shows always a different number than the playerframe.
I found out that if I hover over the playerframe the correct number shows up :S

So I looked in the Functions.lua and change line 302

from

self.value:SetFormattedText("%d|cff%02x%02x%02x|r", floor(UnitPower(unit) / UnitPowerMax(unit) * 100 + 0.5), color[1] * 255, color[2] * 255, color[3] * 255)

to

self.value:SetFormattedText("%d|cff%02x%02x%02x|r", si(UnitPower(unit)), color[1] * 255, color[2] * 255, color[3] * 255)

now the correct number shows all the time.

edit: maybe this is because my rage is increased by 10? so my max is 110.

commented

Ah, I see where the confusion lies. The power text normally shows a %. In the past this was always the same as the current value for non-mana users, because the max value for rage/energy/focus was generally (if not always?) 100. It looks like you can now have up to 110 rage -- 20 / 110 = 18%, which is the 18 you were seeing (the actual % symbol was hidden) -- and some of the new non-mana power types have max values other than 100 too, so I should just switch those to show the current value instead of a percent.