oUF

97.2k Downloads

Add PostUpdate with args to CPoints element please.

villiv opened this issue ยท 5 comments

commented

4.3 is coming, so I guess oUF 1.6 is coming too. :)

I can not explain what I want in English so ... like this.

if(cpoints.PostUpdate) then
 return cpoints:PostUpdate(unit, cp)
end

If you do not mind, please add an arg to HolyPower and SoulShards elements to know how many points we have.
Or we have to check it again in PostUpdate that is (I think) a kind of waste.

commented

Solved with: cd2519e, 0d49b09 and 48c7340.

commented

Also, your english is fine :)

commented

Thanks for your fast work and kind words. =)

One thing I noticed is that CPoints's callback has no unit arg while HolyPower's and SoulShards' have it.
Those elements are for the certain unit (CPoints is for 'target', HolyPower and ShoulShards are for 'player'), so it lacks consistency I think. Yes, it's not a big deal anyway. :p

commented

You're entirely correct in that. Completely forgot that all three of
those are locked to certain units. :)

commented

Solved with 703bab6 and 1058608.