oUF

97.2k Downloads

Updated ClassIcons for Destro Warlock

PProvost opened this issue ยท 4 comments

commented

Hey haste,

I made some mods to classicons.lua so the same soul-shards icon system works for destruction lock burning embers.

You can see the edits here:
PProvost/ouf_quaiche@624d522

If you'd prefer I can do a clone and pull request, but given the elegance of your lua code I suspect you'll have a neater way to do it than I did.

Regards,

PProvost

commented

Burning embers could be partially full, soul shards are either full or empty. ClassIcons is an element to combine soul shards and the like as they share a similar update process. haste stated on wowinterface some time ago that he would like to combine death knight runes, altmana and some other class power resources that are currently being handled through statusbars in a single element like ClassIcons.

The warlock power bar in the standard ui can be found here: https://github.com/Ketho/wow-ui-source/blob/live/FrameXML/ShardBar.lua

commented

No longer needed in Legion, see #260.

commented

On one side Legion won't be out until Q2/Q3 next year, so closing the issue is kinda stupid, but on the other hand... We're still not supporting it after so many years. :P

commented

Was adding the note mostly to link the two issues together so it won't be forgotten once Legion came :)