oUF

97.2k Downloads

Renaming DruidMana

p3lim opened this issue ยท 6 comments

commented

This was brought up in #268, since the element is no longer exclusive to the druid class it should be renamed.

The two suggestions brought up then were "AdditionalPower" and "AlternatePower".
I would personally prefer the latter, but the name is (somewhat) occupied by the "AltPowerBar" element.

I've marked this down for the 1.7.0 milestone, as it's a breaking change.

commented

I'll vote AlternatePowerBar or AlternatePower because that's what blizzard called theirs.

commented

I'll vote AlternatePowerBar or AlternatePower because that's what blizzard called theirs.

Same reasoning for my preference as well, but we'd have two elements with similar names.
The "UnitPowerBarAlt" as it's actually named could also be renamed however (and these days I don't even have a clue what it's used for).

commented

I would vote for AdditionalPowerBar as this is what Blizzard uses for associated stuff like ADDITIONAL_POWER_BAR_NAME and ADDITIONAL_POWER_BAR_INDEX.

I would vote against AlternatePowerBar since this is already properly used for the AltPowerBar and Blizzard uses it in UnitAlternatePowerInfo and ALTERNATE_POWER_INDEX

Btw there is a diffence between alternate and alternative but the way Blizzard uses it more like both, so AltPowerBar is just the perfect name imho.

commented

I'm with @Rainrider on this one. Same reasons, and that's what I said in #268 (comment). So I vote for AditionalPower(Bar).

commented

I vote for AdditionalPower as well. I have actually already gone ahead with the rename on my end.

commented

Votes in favor of "AdditionalPower", submitted #299.