magic numbers in runebar element can be removed

Question

Evilpaul opened this issue 14 years ago · 2 comments

Evilpaul commented 14 years ago

In patch 4.0.1 Blizzard have added in a constant for the max number of runes (at last), called MAX_RUNES.
http://github.com/tekkub/wow-ui-source/blob/live/FrameXML/RuneFrame.lua#L7

This can be used in the runebar element as the max loop value, rather than the current "magic number" of 6.

haste · Answer 1 · 2010-10-27T17:42:30.000Z

local variable is local!

Evilpaul · Answer 2 · 2010-10-27T17:59:25.000Z

bah, I need to stop reading stuff after a long day at work reading C code with Japanese comments :-/