Castbar no longer works for targettarget
Ali1331 opened this issue ยท 3 comments
In the recent castbar revamp for Shadowlands, the logic for enabling castbar for eventless units was broken.
Prior to the update, only the event registration was guarded by a regex match (Old).
After the update, the entire Enable routine is blocked by the regex match (New) and so the castbar element is never registered and therefore called in UpdateAllElements.
I may have misunderstood this, apologies in that case but locally just reverting the check to be around the events seems to fix the problem.
Thanks
It's done deliberately. It's impossible to use proper unit events on *target
unit, so they're updating via a fairly heavily throttled OnUpdate
, so in the past the castbar would be often out of sync and not showing accurate info because those units' states were updated every 0.5s or so. Those units could literally be dead and no longer exist, but the castbar would still be shown and animating. So after talking about it for a while, that castbar PR was in testing for over a year, we chose to remove support for *target
units altogether. We probably forgot to mention it in our update guide for v10 simply due to the age of that PR.
Ah I see, I hadn't actually found the v10 upgrade guide. It is mentioned in there. That's a shame, weird that Blizzard doesn't fire events for it. Thanks for the response :)