oUF

97.2k Downloads

EclipseBar displayed incorrectly when in a vehicle

Evilpaul opened this issue ยท 5 comments

commented

As reported here: http://www.wowinterface.com/forums/showthread.php?p=216198

Entering a vehicle causes the eclipsebar to remain shown, but with odd values. Probably have to add in a check for when entering/exiting a vehicle and change visibility as required.

commented

Haste, any chance on some feedback on the above patch?

I do not have a Boomkin, Paladin or Warlock on the live realms, so I would like to get any bugs in these elements fixed before the Beta realm goes away.

thanks

commented

Oh hi! I've kinda been neglecting stuff as I've barely been able to type much on the computer for the past weeks, and my computer felt it shouldn't work for a short period. Great timing and such I know.

Anyway; Blizzard has started to show/hide the rune element based on player state, which means oUF should start behaving that way as well. It would probably be better to implement a simple system to toggle these elements within the oUF core. Alternatively do both solutions as only the player unit can have eclipse/holypower/sshards.

GitHub also didn't notify me about your comment it seems :(.

commented

Sorry for the time, it's committed now.

commented

Beta server has been giving me grief tonight, and I cannot get any testing done for a couple of days.

Instead of changing visibility options when entering/exiting a vehicle, then we could hard code the Blizzard API calls to check 'player' unit, rather than the passed in unit value.

I also have some concern that there may be a similar issue with the holypower and soulshards elements. Until I get get some testing done, then that is just speculation though.

commented

Here is a fix that makes each of the new power elements always retrieve information for 'player' rather than the passed in unit.

This fix will give UI display consistent with the RuneBar element that remains displayed when in-vehicle.

https://gist.github.com/668151