Outfitter (Abandoned)

Outfitter (Abandoned)

563k Downloads

TBC 2.5.3 Dropdown menus don't work since new patch

FranckMarcotte opened this issue · 15 comments

commented

Whenever I click the tiny arrow next to a gear set, I get this lua error :

Message: ...rface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:96: attempt to call method 'GetBackdrop' (a nil value)
Time: Tue Jan 18 22:25:07 2022
Count: 1
Stack: ...rface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:96: attempt to call method 'GetBackdrop' (a nil value)
[string "@interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua"]:96: in function <...rface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:95>
[string "@interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua"]:615: in function <...rface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:613>
[string "@interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua"]:1028: in function OpenAce3Menu' [string "@Interface\AddOns\Outfitter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua"]:1420: in function Show'
[string "@interface\AddOns\Outfitter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua"]:1557: in function `ToggleMenu'
[string "@interface\AddOns\Outfitter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua"]:1503: in function <...tter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:1502>

Locals: frame = LibDropdownFrame0 {
0 =
AcquireButton = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:574
OnBackdropLoaded = defined @interface\SharedXML\Backdrop.lua:144
GetBackdropColor = defined @interface\SharedXML\Backdrop.lua:382
SetupTextureCoordinates = defined @interface\SharedXML\Backdrop.lua:206
OnBackdropSizeChanged = defined @interface\SharedXML\Backdrop.lua:174
HasBackdropInfo = defined @interface\SharedXML\Backdrop.lua:270
SetBackdropBorderColor = defined @interface\SharedXML\Backdrop.lua:414
isDropdownFrame = true
GetEdgeSize = defined @interface\SharedXML\Backdrop.lua:180
Release = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:547
ApplyBackdrop = defined @interface\SharedXML\Backdrop.lua:286
SetBackdrop = defined @interface\SharedXML\Backdrop.lua:321
ClearBackdrop = defined @interface\SharedXML\Backdrop.lua:274
GetRoot = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:240
GetBackdropBorderColor = defined @interface\SharedXML\Backdrop.lua:401
GetBackdrop = defined @interface\SharedXML\Backdrop.lua:339
AddButton = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:215
SetupPieceVisuals = defined @interface\SharedXML\Backdrop.lua:238
SetBackdropColor = defined @interface\SharedXML\Backdrop.lua:391
Refresh = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:230
SetBorderBlendMode = defined @interface\SharedXML\Backdrop.lua:258
}
(*temporary) = nil
(*temporary) = GameTooltip {
0 =
SetQuestLogRewardSpell = defined @interface\AddOns\Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua:428
GetBackdropColor = defined @interface\SharedXML\SharedTooltipTemplates.lua:182
SetHyperlink = defined =[C]:-1
SetTradeSkillItem = defined @interface\AddOns\Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua:428
SetBackdropBorderColor = defined @interface\SharedXML\SharedTooltipTemplates.lua:186
SetCraftItem = defined @interface\AddOns\Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua:428
SetQuestRewardSpell = defined @interface\AddOns\Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua:428
MAMover = TooltipMover {
}
comparing = false
SetSocketGem = defined =[C]:-1
TopOverlay = {
}
GetBackdropBorderColor = defined @interface\SharedXML\SharedTooltipTemplates.lua:190
SetPetAction = defined @interface\AddOns\Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua:428
SetUnitDebuff = defined =[C]:-1
SetItemByID = defined =[C]:-1
SetLootItem = defined @interface\AddOns\Auc-Advanced\Libs\LibExtraTip\LibE

commented

Confirmed broken for me as well and several others.

Interesting that the GetBackDrop call is at issue here - this is the same function that breaks if you want to build a gear set based on stats - something that also has been broken in BCC.

commented

Looking like the same/similar error after update :

Message: ...rface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:97: attempt to call method 'GetBackdrop' (a nil value)
Time: Wed Jan 19 22:08:29 2022
Count: 1
Stack: ...rface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:97: attempt to call method 'GetBackdrop' (a nil value)
[string "@interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua"]:97: in function <...rface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:95>
[string "@interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua"]:616: in function <...rface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:614>
[string "@interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua"]:1029: in function OpenAce3Menu' [string "@Interface\AddOns\Outfitter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua"]:1420: in function Show'
[string "@interface\AddOns\Outfitter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua"]:1557: in function `ToggleMenu'
[string "@interface\AddOns\Outfitter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua"]:1503: in function <...tter\Libraries/MC2UIElementsLib/MC2UIElementsLib.lua:1502>

Locals: frame = LibDropdownFrame0 {
0 =
AcquireButton = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:575
OnBackdropLoaded = defined @interface\SharedXML\Backdrop.lua:144
GetBackdropColor = defined @interface\SharedXML\Backdrop.lua:382
SetupTextureCoordinates = defined @interface\SharedXML\Backdrop.lua:206
OnBackdropSizeChanged = defined @interface\SharedXML\Backdrop.lua:174
HasBackdropInfo = defined @interface\SharedXML\Backdrop.lua:270
SetBackdropBorderColor = defined @interface\SharedXML\Backdrop.lua:414
isDropdownFrame = true
GetEdgeSize = defined @interface\SharedXML\Backdrop.lua:180
Release = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:548
ApplyBackdrop = defined @interface\SharedXML\Backdrop.lua:286
SetBackdrop = defined @interface\SharedXML\Backdrop.lua:321
ClearBackdrop = defined @interface\SharedXML\Backdrop.lua:274
GetRoot = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:241
GetBackdropBorderColor = defined @interface\SharedXML\Backdrop.lua:401
GetBackdrop = defined @interface\SharedXML\Backdrop.lua:339
AddButton = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:216
SetupPieceVisuals = defined @interface\SharedXML\Backdrop.lua:238
SetBackdropColor = defined @interface\SharedXML\Backdrop.lua:391
Refresh = defined @interface\AddOns\Outfitter\Libraries/LibDropdown-1.0.lua:231
SetBorderBlendMode = defined @interface\SharedXML\Backdrop.lua:258
}
(*temporary) = nil
(*temporary) = {
0 =
SetCenterColor = defined @interface\SharedXML\NineSlice.lua:224
GetFrameLayoutTextureKit = defined @interface\SharedXML\NineSlice.lua:213
Center = {
}
GetBorderColor = defined @interface\SharedXML\NineSlice.lua:249
TopRightCorner = {
}
TopLeftCorner = {
}
RightEdge = {
}
OnLoad = defined @interface\SharedXML\NineSlice.lua:217
TopEdge = {
}
BottomEdge = {
}
GetCenterColor = defined @interface\SharedXML\NineSlice.lua:231
SetBorderBlendMode = defined @interface\SharedXML\NineSlice.lua:261
GetFrameLayoutType = defined @interface\SharedXML\NineSlice.lua:209
BottomRightCorner = {
}
SetBorderColor = defined @interface\SharedXML\NineSlice.lua:238
LeftEdge = {
}
BottomLeftCorner = {
}
}
(*temporary) = "attempt to call method 'GetBackdrop' (a nil value)"
GameTooltip = GameTooltip {
0 =
SetQuestLogRewardSpell = defined @interface\AddOns\Auc-Advanced\Libs\LibExtraTip\LibExtraTip.lua:428
GetBackdropColor = defined @int

commented

I thought it might be that, not sure why it worked for @balder89 , I'll do my best to fix it off memory. I don't have an active wow sub and haven't played since the launch week of tbcc.

commented

Also broken for me.

commented

I'm down to fund your wow sub + tip if you're gonna look into it! Love your add-on <3

commented

Reopen if you have any further issues.

Thanks to @balder89 for the code fixes.

commented

The drop downs still don't work for me even with the latest update.

commented

Can you post the new error?

commented

I have raised a PR to address this, in the meantime you can make the same change locally if you need until a new version is released

commented

Thanks for the fix @MotherGinger , the second commit appears to have broken the drop downs again for me but I applied the first commit manually and have managed to get it working again at least, UI issues notwithstanding.

commented

First of all, sorry for the half (?) fix and for the late answer :/. Second, sorry for my english.

@cdmichaelb it's a very good question :/... btw it's still working for me, so I don't fully understand why it doesn't work for the others :/.

Anyway thanks for the fix @MotherGinger, I manually applied your whole fix (both commits), and it works for me.

commented

Thanks for the fix @MotherGinger , the second commit appears to have broken the drop downs again for me but I applied the first commit manually and have managed to get it working again at least, UI issues notwithstanding.

I've added a couple more adjustments, I was able to replicate what you were seeing with elvui disabled, it looks like certain addons might be setting backdrops of their own that might be tripping it up (GameTooltip is a notorious globally shared object), but I can't be certain

I've added a guard to make sure it works when the tooltip doesn't seem to have a backdrop, let me know if that works out

commented

@MotherGinger Amazing work. I needed this.
Also struggling with Fontain (old font replacement addon) that loads but /fontain doesn't bring up the backdrop and dropdown. Any clues?

commented

@MotherGinger Amazing work. I needed this. Also struggling with Fontain (old font replacement addon) that loads but /fontain doesn't bring up the backdrop and dropdown. Any clues?

I've posted a reply on their curseforge page

commented

Working now though. (=