Lunarpower and Holypower Conditions Incorrect
Ophidon opened this issue ยท 0 comments
While thinking about the power type problem in the previous issue I remembered another important correction I made to the 7.3.9-alpha that does not appear to be corrected in the new official builds as of yet.
In conditions.lua the AstralPower() condition has been properly updated to check the renamed lunarpower, however the other calls AstralPowerDeficit() and AstralPowerCost() are still trying to check the no longer existing "astralpower" power type. Further, should MaxAstralPower() be a condition that exists? It doesn't.
Also, holypower seems to have been properly updated except one case was missed, for MaxHolyPower() where it is still trying to check against the "holy" power type instead of the renamed "holypower".
There might be issues for other classes/power types that I haven't checked. When present, this condition check failure tends to quite thoroughly break expected script functionality without producing actual errors.