Protection Warrior spells need updating
MagisterGollan opened this issue · 3 comments
OvaleCompile is trying to use Battle Cry and Neltharion's Fury which no longer exist in 8.0.
Protection warrior script is not updated as there are no simulationcraft profiles for protection warrior
It’s actually doing a decent job bar the compilation errors. It even
suggests using the new spell Avatar on cool down.
On Sun, Aug 19, 2018 at 17:56, Michał Wojtkowski ***@***.***> wrote:
Protection warrior script is not updated as there are no simulationcraft
profiles for protection warrior
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#477 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AoNHxTtAQiB6EYgEKaRdUZzdVR74l9FMks5uSRoQgaJpZM4WCxZr>
.
--
Andrew Gollan
*"bis vincit quī sē vincit"*
Classics Instructor at Large
@MagisterGollan yes because I've updated warrior spells including protection, but like I said there is no profile for protection warrior in simulation craft so at this moment all you can choose is that Icy Veins/7.0 profile
looking at Icy-Veins profile this should work (put it in custom)
Include(ovale_common)
Include(ovale_trinkets_mop)
Include(ovale_trinkets_wod)
Include(ovale_warrior_spells)
AddCheckBox(opt_interrupt L(interrupt) default specialization=protection)
AddCheckBox(opt_melee_range L(not_in_melee_range) specialization=protection)
AddCheckBox(opt_warrior_protection_aoe L(AOE) default specialization=protection)
AddFunction ProtectionHealMe
{
unless(DebuffPresent(healing_immunity_debuff))
{
if HealthPercent() < 70 Spell(victory_rush)
if HealthPercent() < 85 Spell(impending_victory)
if (HealthPercent() < 35) UseHealthPotions()
}
}
AddFunction ProtectionGetInMeleeRange
{
if CheckBoxOn(opt_melee_range) and not InFlightToTarget(intercept) and not InFlightToTarget(heroic_leap)
{
if target.InRange(intercept) Spell(intercept)
if SpellCharges(intercept) == 0 and target.Distance(atLeast 8) and target.Distance(atMost 40) Spell(heroic_leap)
if not target.InRange(pummel) Texture(misc_arrowlup help=L(not_in_melee_range))
}
}
AddFunction ProtectionInterruptActions
{
if CheckBoxOn(opt_interrupt) and not target.IsFriend() and target.Casting()
{
if target.InRange(pummel) and target.IsInterruptible() Spell(pummel)
if target.InRange(storm_bolt) and not target.Classification(worldboss) Spell(storm_bolt)
if target.InRange(intercept) and not target.Classification(worldboss) and Talent(warbringer_talent) Spell(intercept)
if target.Distance(less 10) and not target.Classification(worldboss) Spell(shockwave)
if target.InRange(quaking_palm) and not target.Classification(worldboss) Spell(quaking_palm)
if target.Distance(less 5) and not target.Classification(worldboss) Spell(war_stomp)
if target.InRange(intimidating_shout) and not target.Classification(worldboss) Spell(intimidating_shout)
}
}
AddFunction ProtectionOffensiveCooldowns
{
Spell(avatar)
#Spell(battle_cry)
if (Talent(booming_voice_talent) and RageDeficit() >= Talent(booming_voice_talent)*40) Spell(demoralizing_shout)
}
#
# Short
#
AddFunction ProtectionDefaultShortCDActions
{
ProtectionHealMe()
#if ArmorSetBonus(T20 2) and RageDeficit() >= 26 Spell(berserker_rage)
if IncomingDamage(5 physical=1) and SpellCharges(shield_block) == SpellMaxCharges(shield_block) Spell(shield_block)
if Rage() >= 60 Spell(ignore_pain)
# range check
ProtectionGetInMeleeRange()
}
#
# Single-Target
#
AddFunction ProtectionDefaultMainActions
{
Spell(shield_slam)
if Talent(devastatator_talent) and BuffPresent(revenge_buff) Spell(revenge)
if BuffPresent(vengeance_revenge_buff) Spell(revenge)
Spell(thunder_clap)
if BuffPresent(revenge_buff) Spell(revenge)
Spell(storm_bolt)
Spell(devastate)
}
#
# AOE
#
AddFunction ProtectionDefaultAoEActions
{
Spell(ravager)
Spell(revenge)
Spell(thunder_clap)
Spell(shield_slam)
if Enemies() >= 3 Spell(shockwave)
Spell(devastate)
}
#
# Cooldowns
#
AddFunction ProtectionDefaultCdActions
{
ProtectionInterruptActions()
ProtectionOffensiveCooldowns()
if IncomingDamage(1.5 magic=1) > 0 Spell(spell_reflection)
if (HasEquippedItem(shifting_cosmic_sliver)) Spell(shield_wall)
Item(Trinket0Slot usable=1 text=13)
Item(Trinket1Slot usable=1 text=14)
Spell(demoralizing_shout)
Spell(shield_wall)
Spell(last_stand)
}
#
# Icons
#
AddIcon help=shortcd specialization=protection
{
ProtectionDefaultShortCDActions()
}
AddIcon enemies=1 help=main specialization=protection
{
ProtectionDefaultMainActions()
}
AddIcon checkbox=opt_warrior_protection_aoe help=aoe specialization=protection
{
ProtectionDefaultAoEActions()
}
AddIcon help=cd specialization=protection
{
ProtectionDefaultCdActions()
}