Ovale Spell Priority

Ovale Spell Priority

6M Downloads

Druid - Feral - compile warning for lunar_empowerment_buff

Fringetastic opened this issue ยท 4 comments

commented

When using scripts as a feral, in feral form, with the balance affinity talent, warning messages are printed:

[03:32:12] OvaleCompile: Warning: lunar_empowerment_buff is not a parameter keyword in 'lunar_strike' spell_aura_list
[03:32:12] OvaleCompile: Warning: lunar_empowerment_buff is not a parameter keyword in 'lunar_strike' spell_aura_list
[03:32:13] OvaleCompile: Warning: lunar_empowerment_buff is not a parameter keyword in 'lunar_strike' spell_aura_list
[03:32:13] OvaleCompile: Warning: lunar_empowerment_buff is not a parameter keyword in 'lunar_strike' spell_aura_list

At line 429 in dist/scripts/ovale_druid_spells.lua, there's this chunk of code:

# Balance Affinity
Define(moonkin_form 197625)
	SpellInfo(moonkin_form to_stance=druid_moonkin_form)
	SpellInfo(moonkin_form unusable=1 if_stance=druid_moonkin_form)

	SpellAddBuff(lunar_strike lunar_empowerment_buff=0)

Commenting out line 434 ("SpellAddBuff(lunar_strike lunar_empowerment_buff=0)") stops the error, so I've been making and re-making this change with every release. Can you change ovale_druid_spells.lua to do this, to comment out that line?

commented

I should have included this link. The idea to comment out that line is Shmoo's.
http://www.fluiddruid.net/forum/viewtopic.php?f=3&t=5709&sid=b14cd658feba8a472706941a11f8f269&start=875#p39108

That line is in two places (434 and ~520, iirc) and I tested it out this afternoon. I could leave line ~520 in and not get the error. I do not know if this affects balance druids.

commented

It shouldn't affect Balance druids, looking into it a bit. Try out the changes as proposed in Hemario@e482167 and tell me if this looks ok to you.

commented

It's weird because I cannot reproduce the error. But I will trust you that the fix is good.

commented

Sorry for the delay. Have been using for the past 30 minutes without a problem, seems good to me. Thank you!