Ovale Spell Priority

Ovale Spell Priority

6M Downloads

Kyrian Rogue "animacharged" combo points

johnnylam88 opened this issue ยท 1 comments

commented

Kyrian rogues gain the covenant ability Echoing Repreimand that causes one of their combo points to be "animacharged". Using a combo point ability that consumes exactly that many combo points will behave as if it consumed 7 combo points. This has an effect on spells where the number of combo points consumed affects the duration of the spell, e.g, Slice and Dice, which should affect the value returned by BaseDuration(slice_and_dice).

I propose adding a new property as_${powerType} to be used like:

Define(slice_and_dice 315496)
    SpellInfo(slice_and_dice duration=6 combopoints=1 set_combopoints=0 add_duration_combopoints=6)
    SpellRequire(slice_and_dice as_combopoints set=7 enabled=(IsAnimaCharged()))

AddFunction IsAnimaCharged
{
    (ComboPoints() == 4 and BuffPresent(323560)) or (ComboPoints() == 2 and BuffPresent(323558)) or (ComboPoints() == 3 and BuffPresent(323559))
}

This allows for describing the mechanics in the script instead of adding more code to src/data/Power.ts to handle this unique Animacharged mechanic.

commented

I'm not sure about the as_combopoints syntax, but I see the idea.