Ovale Spell Priority

Ovale Spell Priority

6M Downloads

refactor: refresh logic is spread throughout the codebase

johnnylam88 opened this issue ยท 2 comments

commented

There are far too many places that call this.Ovale.needRefresh() in the codebase. We should be using events to trigger a frame refresh instead. There is already some work in place to have individual state modules raise events on changes, but all of those events should be caught by the ui/Frame module where all of the refresh logic should be encapsulated.

commented

Issue #749 is related to this.

commented

I think when I was working on this codebase a few years ago, I put way too many events and event handlers into the modules. This does need to be incrementally cleaned up to remove many of the events and replace them with methods that can be called directly by other modules.