Ovale Spell Priority

Ovale Spell Priority

6M Downloads

Importer translates covenant.<name> to iscovenant("<name>")

johnnylam88 opened this issue ยท 3 comments

commented

The importer is putting quotes around the name of the covenant in the IsCovenant() condition within the scripts, e.g., IsCovenant("kyrian").

commented

I believe this comes from UnparseString() in engine/ast.ts. We can check whether the string value has whitespace and drop the enclosing double-quotes if there is none.

commented

I removed the pullup that referenced this issue. I see the work that's being put into doing typed conditions and having this change seems like unnecessary syntantic sugar.

commented

I'm closing this issue. The stricter type-checking is better. I might do a pull-up request for removing the implicit type-casting from variable name to string that is present in some places in the code. The SimulationCraft modules will also need to be audited to not output strings without quotes.