Yesterday the WW script was running flawless; I could go zombie mode in a 5-man and do outrageous damage with no effort. Today, the script is running...weird. I didn't really notice there was a problem at all until it kept suggesting Whirling Dragon Punch when Rising Sun Kick hadn't yet been used, and also kept spamming to use Spinning Crane Kick with no chi. The timing seems off too. Sorry if I didn't use the best language for this kinda stuff, not a sim-craft/coder guy, just a grateful user.
Thanks!

What was the version you were running yesterday and today?

For the Whirling Dragon Punch, it seems that it is an issue with how simulationcraft works.
simc uses the ready() override in order to check whether the spell is ready instead of adding it to the default script

the script just says: actions+=/whirling_dragon_punch

while in sc_monk.cpp we can see (line 3318):

virtual bool ready() override
{
// Only usable while Fists of Fury and Rising Sun Kick are on cooldown.
if ( p() -> cooldown.fists_of_fury -> down() && p() -> cooldown.rising_sun_kick -> down() )
return monk_melee_attack_t::ready();
return false;
}

We will probably need to translate the action from simc into an Ovale if statement where we check the cooldowns of RSK and FoF.

Let me confirm that to you. I guess it shouldn't be an issue anymore with the extra conditions in the APL

The thing is that is how Blizzard has coded the ready().

However!!!!! I updated SimC's Action Priority List earlier today with it explicitly saying to use WDP when FoF and RSK are on cooldown.

actions+=/whirling_dragon_punch,if=cooldown.fists_of_fury.remains>0&cooldown.rising_sun_kick.remains>0

I also did a bit of a revamp to Serenity APL. So Ovale may need a regeneration of the script.

Doesn't that make the implementation of ready() redundant and unnecessary ?

it does but I was mostly putting it in for you and any other priority mod developers. I can take it out.

Is the issue corrected?