Not working in Dragonflight (Provisional update for 10.0.2 inside)
tflo opened this issue · 11 comments
In Dragonflight, Paragon does not work and throws this error:
25x Interface/AddOns/Paragon/Core.lua:191: attempt to call global 'GetFriendshipReputation' (a nil value)
[string "@Interface/AddOns/Paragon/Core.lua"]:191: in function <Interface/AddOns/Paragon/Core.lua:180>
[string "@Interface/AddOns/Paragon/Core.lua"]:646: in function <Interface/AddOns/Paragon/Core.lua:634>
According to WoWPedia, in Dragonflight GetFriendshipReputation
has been replaced with C_GossipInfo.GetFriendshipReputation
.
By changing this (Core.lua, line 191), plus a couple of nil checks for non returned barMin
values in the same function, I was able to get it to work provisionally. Though, I have not investigated further why no values are returned, can be a Blizz bug or another API change.
Here the patched Core.lua file: https://d.pr/f/unj6B2 . Just replace the old one inside the Paragon addon folder.
The C_GossipInfo.GetFriendshipReputation
change is essential and correct due to the API changes, however the 3 added nil checks are provisonal hacks, i.e. they just make the addon working, but they do not eliminate the cause of missing min values.
That being said, so far it is working for me, but I'm using it mainly with Legion rep tokens, maybe it freaks out or gives wrong values with other reputations. Double-check the values the addon returns!
Edit 2022-11-16: Do not use this patch with 10.0.2. Scroll down a few posts for a 10.0.2-compatible version.
Thank you very much, Tflo ! Worked perfectly. I'm also using it mostly for Legion rep.
Hello tflo, could you please share a link to download the version you have been able to repair ? I really need this addon, thank you !
OK, here is a working version for 10.0.2. It's the whole addon this time, as I have updated the toc file too. Use with caution!
Paragon - Inofficial and hackish patch for 10.0.2 - v2.zip
Known issues:
If you have an item comparison tooltip (eg hovering over a gear item in your bags with the Shift key down, or hovering over a gear item in a merchant frame), then the addon throws a 'GetItem' error. This shouldn't affect the normal functionality though. (If I find the time I will try to fix it, but my plan is not to do a fullscale maintenance of this addon ;)
Fixed (hopefully). Changed download file above to v2.
Lol, broken again in 10.0.2. They generously changed the whole tooltip API. Looks like this needs some more work than updating a function name…
@vince2paname Please try version 2 from above. This should fix the issue with comparison tooltips.
Sorry I haven't updated the addon yet. I've been considering a complete rewrite including a better interface.
I'll try to get a working version out soon.
I have now released a working version for 10.0.2: Chalcedony 4