Was in a neths lair in mythic plus and this occurred twice

2x Parrot\Data\CombatEvents.lua:124: Usage: GetPlayerInfoByGUID("playerGUID")
[C]: in function GetPlayerInfoByGUID' Parrot\Data\CombatEvents.lua:124: in function value'
Parrot\Code\CombatEvents.lua:1658: in function <Parrot\Code\CombatEvents.lua:1653>
[C]: in function `gsub'
Parrot\Code\CombatEvents.lua:2058: in function <Parrot\Code\CombatEvents.lua:2020>
Parrot\Code\CombatEvents.lua:2178: in function <Parrot\Code\CombatEvents.lua:2175>

Locals:

Do you think something like this in the function retrieveSourceName(info) would help?

if info.sourceID == nil then return end

Since you can sometimes get a nil result for the GUID? Like what if in some of these dungeons it gets confused and assumes the GUID is a non player "unit" and returns nil thus freaking out the GetPlayerInfoByGUID function?

The odd thing is it seems to only happen in very random and odd circumstances in dungeons. I'll give that a try and see if it prevents this issue.

not info.sourceID is basically the same as info.sourceID == nil so I doubt it's that. I have a bunch of debug around it, but as you've probably guessed I haven't been playing much in the past few months. I had originally added some checking to the guid (making sure the first part is "Player'), but it looks like I removed that and didn't include a UnitIsPlayer check. I'll try to run some instances in the next few days, but try adding

	if not UnitIsPlayer(info.sourceName) then
		return info.sourceName
	end

before GetPlayerInfoByGUID and see if that prevents the error

Ok so after running everything I can think of to get this to break again, I have not had a single issue since adding your fix. I think that should take care of this as well as it can.

I am pretty sure you rolled this into the latest update so is it safe to close this as I have not had a single issue with the latest update (2.0.6 i think it is?)

oops, commit closed #7 instead of #17 😒