Addon no longer showing via data broker (e.g., Bazooka)
Gaviin1242 opened this issue · 16 comments
With the change to allow disabling the minimap icon, PasteNG no longer shows up via data broker such as Bazooka. Doesn't even show in the list. It did in the previous versions, including the one where the minimap icon couldn't be disabled.
Okay, so just to be sure - it works with 11.0.2-20240920-1 but not 11.0.2-20240921-1 ?
If that is the case, could you try and revert this line back and see if that makes a difference for you?
185ebd1#diff-0b751b59c9d50ad473976ffed2a401d19dbf2c9fe2d688bc7597b7a95df96cefR75
Line 75
Hmm, I tried reverting to a couple of the most recent versions, and seems the last version where data broker works is 11.0.2-20240912-1. I could have sworn it was working with 920-1, but it's not now.
Okay, that makes sense 🙂
I'll see what needs to be changed for it to work with brokers.
Referring to my comment in #18: Tried it again with Bazooka and all addons except Bazooka and PasteNG unloaded: Still works fine.
Installed Chocolate Bar (a broker addon similar to Bazooka) and tried it with that: Works also.
Just tested with the latest version, and still having an issue. But it's strange.
When I load the game, PasteNG is nowhere to be seen in the Bazooka bar or config. But if I go into the PasteNG options and re-enable the minimap icon, it suddenly shows up in Bazooka (bar and config). I can then disable the minimap icon option, and it stays showing in Bazooka as one would expect. However, once I reload UI or re-log into the game, back to square one (no PasteNG in Bazooka).
Now, if I leave the minimap icon option enabled, then it'll stay in Bazooka and persist between sessions. But... obviously that somewhat defeats the purpose of using the broker addon to centralize addon management vs. using minimap icons. :)
The above description applies to running with just Bazooka and PasteNG enabled, as well as to running all the addons I usually run. I.e., doesn't seem to be caused by a clash with other addons.
Okay, I think I know what is happening.
Let me see if I got it right 🙂
You want the minimap icon disabled, but it still visible in a broker, correct?
I can then disable the minimap icon option, and it stays showing in Bazooka as one would expect. However, once I reload UI or re-log into the game, back to square one
Oh, I can confirm this. After a reload (and with the minimap icon disabled), the LDB icon disappears. Sorry, I didn't properly test this before; I just disabled/enabled the minimap icon without reload, but this doesn't expose the bug.
(And before and after the test, I had both disabled, because the hotkey is back ;)
I'm 99% sure I have figured out what changes I need to make.
I'll test them tonight, and if it works as expected, I'll push a new release 😊
For me, the Titan Panel option disappeared with the 20240922-1 release. I toggled the Enable Minimap Icon (on) and the Titan Panel option appeared. I toggled the Enable Minimap Icon (off) and the Titan Panel option remained.
The Titan Panel option disappears again after logoff / logon.
Auctioneer's SlideBar is also affected the same way, missing on login, toggle Enable Minimap Icon on and off, and the PasteNG icon is now in the SlideBar.
Can confirm, also elvui can't see the databroker.
When minimap icon is hidden the databroker isn't there anymore on list.
I think the code changes I have will solve the issue.
Should get time to test it tomorrow 🙂
I know, that is what I have done in my local development version, just need to test it tomorrow before I release it 😃
The minimap icon visible and the broker visible should be independent. Either let the broker visibility be controlled by the broker (my preference) or make an independent option for it.