PetTracker

PetTracker

13M Downloads

Shadowlands Pre-Patch errors

Meebsy opened this issue · 14 comments

commented

Message: ...ce\AddOns\PetTracker\addons\main\features\gossip.lua:44: hooksecurefunc(): SelectGossipOption is not a function Time: Wed Oct 14 09:49:32 2020 Count: 1 Stack: ...ce\AddOns\PetTracker\addons\main\features\gossip.lua:44: hooksecurefunc(): SelectGossipOption is not a function

Version 8.3.8

commented

Message: ...ddOns\PetTracker\addons\main\features\objectives.lua:78: attempt to index field 'BlocksFrame' (a nil value) Time: Wed Oct 14 09:49:34 2020 Count: 1 Stack: ...ddOns\PetTracker\addons\main\features\objectives.lua:78: attempt to index field 'BlocksFrame' (a nil value)

commented

Here's another one from 9.0.1:

Message: ...Ons\PetTracker\addons\main\classes\maps\rivalPin.lua:37: attempt to call global 'IsQuestFlaggedCompleted' (a nil value)
Time: Wed Oct 14 17:43:40 2020
Count: 10
Stack: ...Ons\PetTracker\addons\main\classes\maps\rivalPin.lua:37: attempt to call global 'IsQuestFlaggedCompleted' (a nil value)

I believe there's "C_QuestLog." missing in front of the funtion name.

I tested the fixes for the other two errors and they seem to work.

commented

this should fix it, BUT it need to be tested!

replace "...\Interface\AddOns\PetTracker\addons\main\features\gossip.lua"

hooksecurefunc('SelectGossipOption', function(index)

with

hooksecurefunc(C_GossipInfo, 'SelectOption', function(index)

this should fix the first error!

also replace "...\Interface\AddOns\PetTracker\addons\main\features\objectives.lua"

local height = DEFAULT_OBJECTIVE_TRACKER_MODULE.BlocksFrame.contentsHeight or 0

with

local height = ObjectiveTrackerFrame.BlocksFrame.contentsHeight or 0

this should fix the second error

And also change in all PetTracker TOC files:

## Interface: 80300

to this:

## Interface: 90001
commented

@fubaWoW

That's an issue with Sushi-3.1, a library which is used in PetTracker:

Jaliborc/Sushi-3.2#10

I've been fixing other bugs lately, I can probably tackle PetTracker and that one if I can get you all as testers.

commented

Count me in as a tester.

commented

How can you make PetTracker work for you?

Until the author returns, make these changes yourself:

I think you can simply download my fork and unzip it overtop of your installation, but I haven't tried that.

Otherwise, you can edit all the individual files:

eb82e4f
8feca83
c485ad9
2cc249c
Jaliborc/Sushi-3.2@d307f68 (I personally just deleted Libs/Sushi-3.1 and re-downloaded it).
Jaliborc/CustomTutorials-2.1@d732865 (not confirmed by me)

comments

I think this is all, but I haven't done anything pet-related in two expansions so I can't even remember all of what this addon does. 😝

If you find future problems, please open a new ticket https://github.com/Jaliborc/PetTracker/issues/new/choose

You can @spiralofhope in there if you think I can help (like if you found a solution!), but I'm not a programmer (no, really)

outstanding issues

commented

And this one:

Message: ...terface\AddOns\PetTracker\addons\battle\listener.lua:101: attempt to call field 'GetDate' (a nil value)
Time: Wed Oct 14 18:07:11 2020
Count: 1
Stack: ...terface\AddOns\PetTracker\addons\battle\listener.lua:101: attempt to call field 'GetDate' (a nil value)
commented

Don't know if it helps but I'm seeing the same error and have more, hopefully useful information:

165x ...ddOns\PetTracker\addons\main\features\objectives.lua:78: attempt to index field 'BlocksFrame' (a nil value)
[string "@PetTracker\addons\main\features\objectives.lua"]:78: in function GetUsedHeight' [string "@PetTracker\addons\main\features\objectives.lua"]:48: in function <...ddOns\PetTracker\addons\main\features\objectives.lua:47> [string "=[C]"]: in function ObjectiveTracker_Update'
[string "@Blizzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua"]:937: in function <...zzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua:936>
[string "=[C]"]: in function GetHeight' [string "@Blizzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua"]:1339: in function <...zzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua:1325> [string "=[C]"]: in function ObjectiveTracker_Update'
[string "@Blizzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua"]:917: in function <...zzard_ObjectiveTracker\Blizzard_ObjectiveTracker.lua:835>

Locals:
self = {
0 =
Lines =

{
}
Index = 1
RegisterMessage = defined @datastore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
UnregisterMessage = defined @datastore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
Update = defined @PetTracker\addons\main\features\objectives.lua:69
Anchor = {
}
SendMessage = defined @datastore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:59
UnregisterSignal = defined @PetTracker\libs\WildAddon-1.0\WildAddon-1.0.lua:78
RegisterEvent = defined @datastore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:90
UnregisterAllMessages = defined @datastore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
MaxEntries = 0
SendSignal = defined @PetTracker\libs\WildAddon-1.0\WildAddon-1.0.lua:82
GetUsedHeight = defined @PetTracker\addons\main\features\objectives.lua:77
OnEnable = defined @PetTracker\addons\main\features\objectives.lua:35
Header = {
}
RegisterSignal = defined @PetTracker\libs\WildAddon-1.0\WildAddon-1.0.lua:74
NewModule = defined @PetTracker\libs\WildAddon-1.0\WildAddon-1.0.lua:68
UnregisterAllEvents = defined @datastore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:174
UnregisterEvent = defined @datastore\libs\CallbackHandler-1.0\CallbackHandler-1.0.lua:153
Tag = "PETTRACKER_"
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index field 'BlocksFrame' (a nil value)"

commented

Another Error that breaks (AGAIN and again) another addon (Handynotes: Vision's of N'Zoth)...
only because of the "Sushi" s h i t dropdown menu... -.-

1x ...PetTracker\libs\Sushi-3.1-4\classes\drops\Dropdown.lua:136: Invalid data provided for `:SetBackdrop`
[string "=[C]"]: in function `assert'
[string "@PetTracker\libs\Sushi-3.1-4\classes\drops\Dropdown.lua"]:136: in function `SetBackdrop'
[string "@PetTracker\libs\Sushi-3.1-4\classes\drops\Dropdown.lua"]:48: in function `New'
[string "@PetTracker\libs\Sushi-3.1-4\classes\drops\Dropdown.lua"]:57: in function `Toggle'
[string "@PetTracker\addons\main\features\mapSearch.lua"]:124: in function `ToggleTrackingTypes'
[string "@PetTracker\addons\main\features\mapSearch.lua"]:71: in function <PetTracker\addons\main\features\mapSearch.lua:71>

Locals:
(*temporary) = false
(*temporary) = "Invalid data provided for `:SetBackdrop`"

commented

Okay gang, things seem to be working well. I'm happy to have helped, but I'm burnt out. :)

It's all packaged into one big pull request for the author.

My update instructions are above.

commented

1st, Another LUA error!

How to Reproduce:
Show "Species" on the WorldMap and just click on any Species Icon on the WorldMap
This will open the Pet Journal and triggers the LUA Error here:

1x ...s\PetTracker\addons\main\classes\abstract\specie.lua:26: attempt to index a nil value
[string "@PetTracker\addons\main\classes\abstract\specie.lua"]:26: in function `GetID'
[string "@PetTracker\addons\main\classes\abstract\pet-Pet.lua"]:33: in function `Display'
[string "@PetTracker\addons\main\classes\maps\speciePin.lua"]:67: in function <...ns\PetTracker\addons\main\classes\maps\speciePin.lua:65>

Locals:
self = <table> {
 specie = 267
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index a nil value"

2nd, The Search bar:
The "Search Bar" stay in actual state (Visible or Invisible) when toggle "Species" on the WorldMap.
But it is visible if "Species" is enabled or invisible of disabled and you Reload the UI!


3rd, Another thing is, the "Search Bar" overlaps the new Map-Pin Button and is non Interactive at all.
Also the "Filter Text" overlaps the actual Search Text!
image
Seems there is something wrong in function MapSearch:UpdateFrames()


and another one...

How to Reproduce:
ESC - Interface -> trigger this here:

1x ...ker\libs\CustomTutorials-2.1\CustomTutorials-2.1-10.lua:150: attempt to call method 'SetBackdrop' (a nil value)
[string "@PetTracker\libs\CustomTutorials-2.1\CustomTutorials-2.1-10.lua"]:150: in function <...ker\libs\CustomTutorials-2.1\CustomTutorials-2.1.lua:125>
[string "@PetTracker\libs\CustomTutorials-2.1\CustomTutorials-2.1-10.lua"]:181: in function `RegisterTutorials'
[string "@PetTracker\addons\config\tutorials.lua"]:43: in function `Load'
[string "@PetTracker\addons\config\tutorials.lua"]:27: in function `?'
[string "@PetTracker\libs\WildAddon-1.0\WildAddon-1.0-1.lua"]:20: in function <...dOns\PetTracker\libs\WildAddon-1.0\WildAddon-1.0.lua:18>
[string "@PetTracker\libs\WildAddon-1.0\WildAddon-1.0-1.lua"]:56: in function <...dOns\PetTracker\libs\WildAddon-1.0\WildAddon-1.0.lua:53>
[string "=[C]"]: ?
[string "@TradeSkillMaster\External\EmbeddedLibs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:29: in function <...ddedLibs\CallbackHandler-1.0\CallbackHandler-1.0.lua:25>
[string "@TradeSkillMaster\External\EmbeddedLibs\CallbackHandler-1.0\CallbackHandler-1.0-7.lua"]:64: in function `Fire'
[string "@ArkInventory\Externals\Ace3\AceEvent\AceEvent-3.0-4.lua"]:120: in function <...rkInventory\Externals\Ace3\AceEvent\AceEvent-3.0.lua:119>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@PetTracker\addons\main\main.lua"]:44: in function <PetTracker\addons\main\main.lua:44>
[string "=[C]"]: in function `Show'
[string "@FrameXML\UIParent.lua"]:2893: in function `SetUIPanel'
[string "@FrameXML\UIParent.lua"]:2699: in function `ShowUIPanel'
[string "@FrameXML\UIParent.lua"]:2606: in function <FrameXML\UIParent.lua:2602>
[string "=[C]"]: in function `SetAttribute'
[string "@FrameXML\UIParent.lua"]:3457: in function <FrameXML\UIParent.lua:3436>
[string "=[C]"]: in function `ShowUIPanel'
[string "@FrameXML\UIParent.lua"]:3482: in function `ShowOptionsPanel'
[string "*:OnClick"]:2: in function <[string "*:OnClick"]:1>
commented

local height = ObjectiveTrackerFrame.BlocksFrame.contentsHeight or 0

im not seeing the second fix in the lua this one
also replace "...\Interface\AddOns\PetTracker\addons\main\features\objectives.lua"

local height = DEFAULT_OBJECTIVE_TRACKER_MODULE.BlocksFrame.contentsHeight or 0
with

local height = ObjectiveTrackerFrame.BlocksFrame.contentsHeight or 0
this should fix the second error

here is my objectives.lua
--[[
Copyright 2012-2020 João Cardoso
PetTracker is distributed under the terms of the GNU General Public License (Version 3).
As a special exception, the copyright holders of this addon do not give permission to
redistribute and/or modify it.

This addon is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with the addon. If not, see http://www.gnu.org/licenses/gpl-3.0.txt.

This file is part of PetTracker.
--]]

if IsAddOnLoaded('Carbonite.Quests') then
return
end

local ADDON, Addon = ...
local Parent, HeaderButton = ObjectiveTrackerBlocksFrame, ObjectiveTrackerFrame.HeaderMenu
local Objectives = Addon:NewModule('Objectives', Addon.Tracker(Parent))

do
OBJECTIVE_TRACKER_ADDONS = OBJECTIVE_TRACKER_ADDONS or {}
tinsert(OBJECTIVE_TRACKER_ADDONS, 0)
Objectives.Index = #OBJECTIVE_TRACKER_ADDONS
end

--[[ Startup ]]--

function Objectives:OnEnable()
local header = CreateFrame('Button', nil, self, 'ObjectiveTrackerHeaderTemplate')
header:SetScript('OnClick', self.ToggleDropdown)
header:RegisterForClicks('anyUp')
header:SetPoint('TOPLEFT')
header.Text:SetText(PETS)
header:Show()

self.Anchor:SetPoint('TOPLEFT', header, 'BOTTOMLEFT', -4, -10)
self.Anchor:SetScript('OnMouseDown', self.ToggleOptions)
self.Header = header

hooksecurefunc('ObjectiveTracker_Update', function()
	local off = self:GetUsedHeight()
	local availableEntries = floor(((Parent.maxHeight or 0) - off - 45) / 20)

	if availableEntries ~= self.MaxEntries then
		self.MaxEntries = availableEntries
		self:Update()
	end

	self:SetPoint('TOPLEFT', Parent, -10, -off)
end)

HeaderButton:HookScript('OnHide', function()
	if self:IsShown() then
		HeaderButton:Show()
	end
end)

end

--[[ API Override ]]--

function Objectives:Update()
self:GetClass().Update(self)
self:SetShown(Addon.sets.trackPets and self.Anchor:IsShown())

HeaderButton:SetShown(Parent.currentBlock or self:IsShown())
OBJECTIVE_TRACKER_ADDONS[self.Index] = self:IsShown() and self:GetHeight() or 0

end

function Objectives:GetUsedHeight()
local height = Parent.contentsHeight or 0
for i = 1, self.Index-1 do
height = height + OBJECTIVE_TRACKER_ADDONS[i]
end

if height > 0 then
	height = height + 15
end

return height

end

I just updated it and have pre shadowlands. i was told in my ticket on my lua errors this was post was my fix
ty for any help

commented

it is also not fixed when click on a Pet-Pin on the Worldmap!

1x ...s\PetTracker\addons\main\classes\abstract\specie.lua:26: attempt to index a nil value
[string "@PetTracker\addons\main\classes\abstract\specie.lua"]:26: in function `GetID'
[string "@PetTracker\addons\main\classes\abstract\pet-Pet.lua"]:33: in function `Display'
[string "@PetTracker\addons\main\classes\maps\speciePin.lua"]:67: in function <...ns\PetTracker\addons\main\classes\maps\speciePin.lua:65>

Locals:
self = <table> {
 specie = 389
}
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index a nil value"

but -> "issue closed"...

commented

For anyone still having errors, please

This will keep things clean for the developer.