PetTracker

PetTracker

Addons
13M Downloads

Pet Tracker interfering with the buttons on the map

Daeveren opened this issue · 5 comments

commented

Running Software (issues missing this information will be deleted):

  • Addon version: 9.0.1
  • Server patch: 9.0.1

Have you read the changelog? (please don't waste our time)
Always

Describe the bug
The addon is interfering with other addons that add buttons on the map, as seen in the screenshots below

Screenshots
With Pet Tracker loaded, when I mouse over both these buttons it shows the same thing which is anyway wrong on both:
image
image

Also I've made a gif here https://gfycat.com/prestigiousfreeegret

Now, the same 2 buttons if I disable Pet Tracker:
image
image

Note how for the right button, with Pet Tracker enabled, it was completely hiding the RareScanner section; also wtih Pet Tracker enableed, for the tooltip on the left side (one from Handy Notes: Battle for Azeroth) it's completely replacing the tooltip and instead of showing the real addon tooltip, it duplicates the one from the right button.

Error Logs
No lua errors are shown at all.

commented

This issue has gotten worse, PetTracker removes almost all menu entries.

Without PetTracker:
image

With PetTracker:
image

commented

This is still an issue with latest update...

commented

Temporary bypass:
in addons\main\features\mapSearch.lua, comment out line 75:
--overlay:SetScript('OnMouseDown', function() self:ToggleTrackingTypes(overlay) end)

Note this would also disable toggling feature for pettracker on the map button.

commented

It looks like the menu is being replaced.

I suggest taking a look at how RareScanner is interacting with this menu. They do this by secure hooking the InitializeDropDown event for the frame and adding to the frame using UIDropDownMenu_AddSeparator, UIDropDownMenu_CreateInfo, and UIDropDownMenu_AddButton. This is done in the following file in RareScanner: RareScanner/Core/Service/RSWorldMapHooks.lua.

commented