[Bug] Bottom indicators alignment
a2line opened this issue · 27 comments
If by "I'm trying" you mean you are editing the source, I have added these indicators in a newer version, if you mean the ones I added are not aligned then please correct me, Though in my testing I think mine where more aligned. Either way let me know.
I was also expecting that removing the side indicators 4 would remove the more centered one. Positions looks not intuitive at all. You should perhaps reorder them before they are too much used. For eg. always use
2
1 4
3
… with clockwise rotation of this for all sides?
Here is a screenshot with the four side indicators 1 2 3 only (all current side indicators 4 removed)
What size is your frames? each middle one starts at 1 as far as I Know and the others a aligned around that one Ill look into it.
Thanks, im looking into makeing the changes will try to get a fix out soon like you said before poeple start using all these indicators.
Bottom indicators alignment looks good, thank you for that! The logic of placement still echaps me, for “top” it's 2 in the middle, for “bottom” and “right” it's 4 and for “left” it's 3. Here is the pattern in version 2.0.29:
Bottom
2
3 1 4
Left
2
1 4
3
Right
2
4 1
3
Top
2 1 4
3
2 1 4
2 3 2
1 4 4 1
3 2 3
3 1 4
What I described on previous post would be:
3 1 2
2 4 3
1 4 4 1
3 4 2
2 1 3
And now that I see it, putting 2 in the center is perhaps a better idea, because it makes clockwise little spiral counting from 1 to 4 and it's quite simple to remember for each side:
3 1 4
4 2 3
1 2 2 1
3 2 4
4 1 3
dc6957d is what I got now btw. which should line up with what you posted but you didnt specify for the other corners.
13 3 1 4 2 1
2 1 3
4 3
1 2 2 1
3 4
2 2 2
13 4 1 3 3 1
Right side is not good, you must switch 2 and 4. Trying corners alternative right now, never used them.
github wont keep the formating but this is what it currently looks like
13 3 1 4 2 1
2 1 3
4 3
1 2 2 1
3 4
2 2 2
13 4 1 3 3 1
For corners, applying the same “spiral” idea can be good. For formatting I use (non-breakable spaces). I can do the full one for documentation if you want.
1 2 3 1
3 2
2 3
1 3 2 1
image probably better https://imgur.com/a/joP7xpt
I think thats what I have in 5a4fcd7 now.
And now that we have corner with sides we want to read first row 1 2…4 1 2, top side with 3 in the middle, isn’t it?! Dunno if you wan't to change again. It’s far better than before, thank you! Trying last commit you posted to verify.
5a4fcd7 the last commit I posted should have all the indicators as per your post. I think. Is this the final?
Happy to make changes you think are better. Im not always the most organized so things like this elude me some times.
1 2 4 1 2 3 1
3 3 2
2 4
1 3 3 1
4 2
2 3 3
1 3 2 1 4 2 1
so circular permutation of 2 3 4 gives:
-- left/right up/down
Top = { "TOP", 1, 1 },
Top2 = { "TOP", 6, 1 },
Top3 = { "TOP", 1, -4 },
Top4 = { "TOP", -4, 1 },
-- left/right up/down
Bottom = { "BOTTOM", 1, 0 },
Bottom2 = { "BOTTOM", -4, 0 },
Bottom3 = { "BOTTOM", 1, 5 },
Bottom4 = { "BOTTOM", 6, 0 },
-- left/right up/down
Left = { "LEFT", -1, -1 },
Left2 = { "LEFT", -1, 4 },
Left3 = { "LEFT", 4, -1 },
Left4 = { "LEFT", -1, -6 },
-- left/right up/down
Right = { "RIGHT", 1, -1 },
Right2 = { "RIGHT", 1, -6 },
Right3 = { "RIGHT", -4, -1 },
Right4 = { "RIGHT", 1, 4 },
I prefer that last one because we read the 1st row from left to right (perhaps not everybody on earth…) and apply that scheme to others where it's not anymore our common reading sense. And 2 or 3 in the middle is not intuitive but the whole thing is, we can't have everything. Thank's for your time on this.
ok c1d9771 should now be like your last post.
if you wana just double check rq that would be appreciated make sure everything still aligns as well.
I have checked ingame the code I gave, so just by reading your last commit diff it looks good for me. Edit: alignment was also good since first correction!