Plumber

Plumber

Addons
6M Downloads

Incapability with MerchantFrame addons, like Scrap (Merchant Pride module)

lemieszek opened this issue · 2 comments

commented

Incapability with MerchantFrame addons, like Scrap

Merchant Scrap tab
Image Image

On changing tab to something from other addons the prices stay on top, floating.

commented

I see it is using https://github.com/Jaliborc/SecureTabs-2.0 which is not firing MerchantFrame_Update on changing tabs, even tho visual "tab focus" is changing. I tried to debug for other events but I did not found any events being fired on the tab change.

It calls (shorted curated cut from code)

local name = tab:GetName()
local left = tab.LeftActive or _G[name..'LeftDisabled']
left:SetShown(not selection)

without changing MerchantFrame.selectedTab value nor causing the update to fire (just manual texture hiding/showing)

commented

Hi! I made some adjustments specifically for Scrap, so you should no longer encounter this issue.

  • ❤️1