Plumber

Plumber

6M Downloads

[Bug] Delves "Auto Choose Power" stops working on relogs

patf0rd opened this issue · 4 comments

commented

When we log in when we are already in a delve, the new feature stops working. It continues to work when we enter another delve.

Example: We have to relog because we run into the PlayerChoice issue ("...you already have a choice open...") caused by opening similar panels like the D.I.S.C. Belt abilities or a C.H.E.T.T. List in a delve before we try to grab a delve power.

commented

Hi! This is not caused by relogging or /reload, but by using the items you mentioned. When it happens, even the default UI will fail, and I'm unable to find a way to programmatically reverse it. So maybe consider not using these items in Delves 🥲

commented

Maybe it would have been less confusing without mentioning the PlayerChoice issue as a reason for a relog ;-)

The issue I tried to describe is that a simple relog inside of a delve is enough to make the new feature stop working. When I relog, I just get the standard widget again, as if the module is only correctly started when I enter a delve, but not when I log in inside of a delve.

I have to admit I didn't test what happens when I disable/re-enable the module after a relog.

commented

Hi again! Sorry, I only tried using CHETT then relogging, but never tried just relogging. Now I have noticed the issue and figured out what went wrong.

I've been using C_DelvesUI.HasActiveDelve(mapID) to determine if the player is in a delve, but this API will fail if you log in inside a delve (always returns false), and this is why the difficulty banner on the top right of the minimap changes its icon after relogging.

I'm going to switch to C_PartyInfo.IsPartyWalkIn(). This API is used to determine if the Leave Delve button on the PlayerFrame context menu should be shown.

commented

Interesting, didn't even notice the icon change, but it was also never my goal to relog a lot ;-) Thanks for investigating!