Plumber and LibEditModeOverride don't play well together
rowaasr13 opened this issue ยท 1 comments
Since Plumber injected its settings into Edit Mode, calling LibEditModeOverride:ApplyChanges() at unexpected time (e.g. soon after PLAYER_ENTERING_WORLD before Plumber initializes some of its own buttons causes Lua errors.
Message: Interface/AddOns/Plumber/Modules/LootUI_Display.lua:1388: attempt to index field 'TakeAllButton' (a nil value)
Time: Tue Mar 11 02:58:11 2025
Count: 4
Stack:
[Interface/AddOns/Plumber/Modules/LootUI_Display.lua]:1388: in function 'ExitEditMode'
[Interface/AddOns/Plumber/Modules/LootUI_Display.lua]:1729: in function 'exitEditMode'
[Interface/AddOns/Plumber/Modules/BlizzardEditMode.lua]:122: in function <...nterface/AddOns/Plumber/Modules/BlizzardEditMode.lua:117>
[C]: ?
[Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua]:144: in function <...e/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:143>
[C]: ?
[Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua]:147: in function 'TriggerEvent'
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeManager.lua]:107: in function 'ExitEditMode'
[Interface/AddOns/Blizzard_EditMode/Mainline/EditModeManager.lua]:125: in function <...ddOns/Blizzard_EditMode/Mainline/EditModeManager.lua:123>
[C]: in function 'Hide'
[Interface/AddOns/Blizzard_UIParentPanelManager/Mainline/UIParentPanelManager.lua]:906: in function <...ParentPanelManager/Mainline/UIParentPanelManager.lua:896>
[C]: in function 'HideUIPanel'
[Interface/AddOns/LibEditModeOverride/LibEditModeOverride.lua]:206: in function 'ApplyChanges'
Hi! Thanks for the report. It has been fixed in our latest update.
It's an oversight on my end, and it has nothing particular to do with this lib. The issue happened when you didn't enable Plumber Loot UI and entered Edit Mode. The TakeAllButton won't be created (thus being nil) until Loot UI is enabled.