Premade Groups Filter

Premade Groups Filter

Addons
12M Downloads

matchingid fails for instance names with pattern characters (nerub-ar palace)

mbattersby opened this issue ยท 1 comments

commented

Sorry I'm ignoring your template because I have the bug and the fix.

matchingid condition fails for nerub-ar palace, and the reason is that it never matches the name.

In PGF.IsMostLikelySameInstance it calls string.find with the pattern matching enabled, and nerub-ar palace has a pattern character '-' in it.

Fix is to change:

if not string.find(instanceNameLower, token) then return false end

to

if not string.find(instanceNameLower, token, nil, true) then return false end

commented

Thanks for the analysis! I'm not sure if I would have found it. New release is on its way.