some objective text contain slain text missing in Chinese Client!
kuletco opened this issue · 26 comments
Bug description
some objective text contain slain text missing in Chinese Client
Screenshots
Questie version
QuestieDev-master: 37acad5
I am busy with work recently.
I read your code of QuestieQuest.lua and I try to fix it.
Now it works fine in the Chinese client.
@BreakBB Test other language clients if you can.
Here's my thinking:
- We should match text that contains colon first, otherwise, the match will return a '', not a nil in Chinese client, I can't test other language clients for the same problem.
- I add two match rules for Chinese client, but I can't test if it has a bad effect on other language clients.
Here are my changes:
What is your exact locale? zhCN?
Can you do a "/dump QUEST_MONSTERS_KILLED" and send me the text and a screenshot for it?
Also "isn't working" doesn't it update correctly? Or is it only displaying the information in an incorrect way?
Can you replace the contents of QuestieQuest.lua with this https://hastebin.com/ajovejuriv.rb and see if it solves the issue!
https://classic.wowhead.com/quest=2681
https://classic.wowhead.com/quest=5282
These two quests have wrong object text. The other types are correct now.
Questie-v5.0.1_2-e2e80b7
Good news is no errors msg on some quests. 😄
some debug msg
Questie: [SPAM] [QuestieQuest:PopulateObjective]
Questie: [SPAM] -->Found: 戈洛尔的仆从
Questie: [SPAM] -->ID: nil
Questie: [SPAM] -->Description: 解放拉瑟莱克的仆从：0/9
Questie: [SPAM] -->Found: 瑟温妮的仆从
Questie: [SPAM] [QuestieQuest]: PopulateMeta: nil 禁锢我们的石头
Questie: [SPAM] -->Description: 解放奥利斯塔的仆从：0/3
Questie: [SPAM] -->Found: nil
Questie: [SPAM] -->ID: 7669
Questie: [SPAM] ----> Objective 解放奥利斯塔的仆从：0/3 Dist: 12
Questie: [SPAM] -->Found: 拉瑟莱克的仆从
Questie: [SPAM] -->ID: 7668
Questie: [SPAM] -->ID: 7671
Questie: [SPAM] [QuestieQuest]: Error finding entry ID for objective event 在壁炉谷中寻找一处高地，在那里观察小镇。
Questie: [SPAM] -->Description: 解放戈洛尔的仆从：0/3
Questie: [SPAM] ----> Objective 解放拉瑟莱克的仆从：0/9 Dist: 12
Questie: [SPAM] -->Found: 奥利斯塔的仆从
Questie: [SPAM] [QuestieQuest:PopulateObjective]
Questie: [SPAM] ----> Objective 解放瑟温妮的仆从：0/3 Dist: 12
Questie: [SPAM] ----> Objective 在壁炉谷中寻找一处高地，在那里观察小镇。 Dist: 0
Questie: [SPAM] -->ID: 7668
Questie: [SPAM] -->Description: 解放瑟温妮的仆从：0/3
bug position.
L_QUEST_MONSTERS_KILLED find nothing in objective.text "解放戈洛尔的仆从：0/3"
print "nil" in game
ah yes @tytannial that logic is incorrect!
I also need to add or not monsterName.
Thanks!
ah yes @tytannial that logic is incorrect!
I also need to add or not monsterName.Thanks!
It works! 🎉
@kuletco 试试最新的提交，似乎解决问题了！
@tytannial Its working as expected? :)
Ill close the issue in a day or two unless you say otherwise!
ah yes @tytannial that logic is incorrect!
I also need to add or not monsterName.
Thanks!It works! 🎉
@kuletco 试试最新的提交，似乎解决问题了！我修改完怎么还是没有解决？地下城任务应该是显示D,还是显示问号
这个单子只是针对任务目标出现的问题，标题的问题你再开一个issue就好了
@tytannial Its working as expected? :)
Ill close the issue in a day or two unless you say otherwise!
Could you update the "QuestieLib:GetColoredQuestName" function?
In non CJK locale this can be easy to get "Dungeon" for "D", but in Chinese you can not get that easily. char = string.sub("地下城", 1, 1), char value is "?". Sub a double byte character
as two code is not cool.😂
ah yes @tytannial that logic is incorrect!
I also need to add or not monsterName.
Thanks!It works! 🎉
@kuletco 试试最新的提交，似乎解决问题了！
我修改完怎么还是没有解决？地下城任务应该是显示D,还是显示问号
ah yes @tytannial that logic is incorrect!
I also need to add or not monsterName.
Thanks!It works! 🎉
@kuletco 试试最新的提交，似乎解决问题了！
好的，谢谢提醒，不过最近我一直忙于工作，没怎么玩儿游戏。
@tytannial What would be appropriate representation of [24D] and [60R] in CJK? Moreover currently we just use + for all quests that are not normal and add (Dungeon) behind them. Maybe we don't need the first part.
@tytannial What would be appropriate representation of [24D] and [60R] in CJK? Moreover currently we just use
+for all quests that are not normal and add(Dungeon)behind them. Maybe we don't need the first part.
[24D] and [60R] is enough, because it is not easy to match them in CJK, also we didn't translate this tag before in quest addons. It's a UTF-8 issue happened because each chinese word actually have 3 characters. The better way is force tag as D/R/E/G for CJK clinet.
@tytannial What would be appropriate representation of [24D] and [60R] in CJK? Moreover currently we just use
+for all quests that are not normal and add(Dungeon)behind them. Maybe we don't need the first part.[24D] and [60R] is enough, because it is not easy to match them in CJK, also we didn't translate this tag before in quest addons. It's a UTF-8 issue happened because each chinese word actually have 3 characters. The better way is force tag as D/R/E/G for CJK clinet.
Agree. 👍
@kuletco @EKE00372 @tytannial @suyunxiu Please try the following version and report if the issue is fixed:
@kuletco @EKE00372 @tytannial @suyunxiu Please try the following version and report if the issue is fixed:
IT WORKS!
@kuletco @EKE00372 @tytannial @suyunxiu Please try the following version and report if the issue is fixed:
'Quest tracker dungeon and raid notation issues # 1529' This issue is fixed in the above file!
Should I use this version instead of downloading the latest version? (Are there any hotfixes for the Korean version?)
@eshukina You should be fine with the file above for now. But we will shortly release a hotfix version containing this fix.