Bug description

Relating to the quest A Noble Brew, the two items relating to the quest have duplicate entries on their tooltips showing the quest they relate to (see screenshot below). I've done some debugging and this appears to be due to the fact that these two items are both looted from GameObjects of the same name. The tooltip-related code in QuestieTooltips.lua appears to perform a GameObject lookup-by-name in every OnUpdate call without checking if the tooltip relates to an item or unit, resulting in it finding a related GameObject by name (since the items share the GameObject's name) and also then finding the related item information. The GameObject code also unconditionally resets the last tooltip type to 'object' every OnUpdate regardless of whether a matching object was found (not technically relevant in this case since a matching object would have been found regardless, but probably sub-optimal).

If there is some way to check if a tooltip relates to an item or unit before doing a GameObject lookup (e.g. by calling :GetItem or :GetUnit on the tooltip as the item/unit code does) that that would seem to solve the problem, but my UI dev is far too rusty to write and submit such a patch.

Screenshots

Questie version

v5.0.1_e2e80b7

Good explanation! Ill look into it!

We are calling GetUnit before doing a GameObject lookup, i also added a check to GetItem and we can see if it help. Have you already turned in the quest?

I still have the quest, I tested your patch and it appears to resolve the issue

@StrangelyTyped Thank you very much for keeping the quest and reporting back on this! Glad it could be fixed this easy 👍