Latest zhCN locale database change in tbc-api-fixes branch not included in master/B2 release
qqytqqyt opened this issue · 3 comments
Description
Wowhead link
Screenshots
Questie version TBC - B2
Hello,
I noticed the branch tbc-api-fixes has been deleted however the changes to the zhCN locale data base was not merged.
E.g. I made a change to add all TBC quests data through this PR #2630 but the quest data from https://github.com/Questie/Questie/blob/master/Localization/lookups/lookupQuests/zhCN.lua was unchanged.
However, the change we made earlier for zhTW (#2623) was included in the latest zhTW locale data.
Will there be any plans that the TBC zhCN locale data will be included in the newly formatted locale code?
Thanks
Uff, damn! :O I am sorry that this happened. I will look into it, reopening another PR to include the data would still be very helpful! 🙏🏻
New PR has been submitted #2800 based on the latest master code
Note that some new entries have already been added through other commits. The PR has corrected some of these entries (mainly because of incomplete data from Wowhead db) after comparing them against in-game data.