Questie

Questie

Addons
116M Downloads

TODO: Check possible bug: Not deleting frames fully?

Laumesis opened this issue ยท 0 comments

commented

Questie/Modules/Map/QuestieMap.lua

Lines 82 to 95 in 80ac103

if iconType == nil then
for _, frame in pairs(QuestieMap:GetFramesForQuest(questId)) do
frame:Unload();
end
QuestieMap.questIdFrames[questId] = nil;
else
for name, frame in pairs(QuestieMap:GetFramesForQuest(questId)) do
if frame and frame.data and frame.data.Icon == iconType then
frame:Unload();
QuestieMap.questIdFrames[questId][name] = nil
_G[name] = nil
end
end
end

First IF-branch does not assign _G[name] = nil while 2nd IF-branch does. Why not? Should it?

I am not sure if _G[frameName] = nil is even necessary after frame:Unload(). I haven't checked at all.