Questie

Questie

122M Downloads

Is Hiding drop-down menus on the World Map workaround still necessary?

gouletr opened this issue ยท 5 comments

commented

Bug description

I am trying to track a taint in my addon, which is currently depending on Questie. And while looking through the taintlog, I saw "hiding drop-down workaround" causing the very first taint:

10/18 13:29:52.252  Global variable WorldMapZoneMinimapDropDown_Update tainted by Questie - Interface\AddOns\Questie\Modules\WorldMapTaintWorkaround.lua:10 doWorkaround()
10/18 13:29:52.252      Interface\AddOns\Questie\Modules\WorldMapTaintWorkaround.lua:27

As mentioned here Stanzilla/WoWUIBugs#165, it looks like the ui dropdown taint has been fixed.

Maybe that workaround should be removed? I tested it locally, and removing the workaround fixed that one taint issue. But I am not sure if there are other issues around it. Can anyone confirm?

Questie & WoW version

Questie 7.4.1
WotLK Classic 3.4.0

commented

Hey @gouletr thanks for reporting this and sorry for the very late response. We have this on our list for quite some time to verify if that work around is still necessary ๐Ÿ™ˆ

commented

guild taint

Seems to still be an issue on WoW 3.4.1/Questie 7.4.8, no taint with Modules\WorldMapTaintWorkaround.lua loaded.

taint.log with CVar set to 11

@gouletr How did you trigger the taint shown in your OP? Just have Questie and your addon loaded and opening guild settings?

commented

@gouletr How did you trigger the taint shown in your OP? Just have Questie and your addon loaded and opening guild settings?

Just Questie, then I think I opened the world map iirc.

commented

This would fix #4147

commented

@MyTechnoHunter would you mind investigating this?