Questie

Questie

116M Downloads

Lua Error when you Try to Use Items in Tracker while in Combat

Gogo1951 opened this issue ยท 4 comments

commented

2x [ADDON_ACTION_FORBIDDEN] AddOn 'Questie' tried to call the protected function 'UseItemByName()'.
[string "@interface\AddOns!BugGrabber\BugGrabber.lua"]:480: in function <Interface\AddOns!BugGrabber\BugGrabber.lua:480>
[string "=[C]"]: in function UseItemByName' [string "@Interface\FrameXML\ChatFrame.lua"]:1150: in function SecureCmdUseItem'
[string "@interface\FrameXML\SecureTemplates.lua"]:412: in function `handler'
[string "@interface\FrameXML\SecureTemplates.lua"]:625: in function <Interface\FrameXML\SecureTemplates.lua:569>

commented

If you have the time for testing, I have an inkling that reverting c00c8ff , specifically removing line 549, might help with this (but reintroduce the collapsing tracker bug).

commented

Yes, seems like reverting c00c8ff makes this bug stop.

commented

I just tried to reproduce this and received no error... I actually remember this bug. It generally happens when the ItemButton is trying to be shown or hidden while in combat which is against the SecureActionButtonTemplate. My fix was to wrap this section of code in the CombatQue. Matter of fact, at one point the player could minimize the Quest but to minimize this issue I just hid the Min/Max button under the ItemButton unless the quest was complete. Then the ItemButton was hidden and the Min/Max button was visible.

Maybe all my recent code changes fixed the original issue. I can use Quest Items from the Questie tracker in and out of combat. Updating the Quest Items Charges and Range indicators also work in and out of combat without issue.

I did however notice that while the option Minimize While In Combat was enabled, the tracker doesn't fully minimize. This fix has been checked into my Fork and should update with my Pull Request.

commented

Fixed in #4664