Questie LUA ERROR when auto accepting multiple quests

Question

Questie LUA ERROR when auto accepting multiple quests

Renier747 opened this issue 2 years ago · 8 comments

Renier747 commented 2 years ago

Bug description

Screenshots

Questie & WoW version

Dyaxler · Answer 1 · 2023-03-08T01:14:32.000Z

It does help. Thank you. It's erroring out on a Debug line that's trying to read the Quest Title. I can add a "title" check to that statement to make sure it's there before passing it to the Debug function.

Renier747 · Answer 2 · 2023-03-07T10:52:59.000Z

Message: Interface/AddOns/Questie/Modules/Auto/Privates.lua:38: attempt to concatenate local 'title' (a boolean value)
Time: Tue Mar 7 10:47:23 2023
Count: 3
Stack: Interface/AddOns/Questie/Modules/Auto/Privates.lua:38: attempt to concatenate local 'title' (a boolean value)
[string "=[C]"]: ?
[string "@Interface/AddOns/Questie/Modules/Auto/Privates.lua"]:38: in function CompleteQuestFromGossip' [string "@Interface/AddOns/Questie/Modules/Auto/QuestieAuto.lua"]:78: in function GOSSIP_SHOW'
[string "@Interface/AddOns/Questie/Modules/QuestieEventHandler.lua"]:77: in function <...rface/AddOns/Questie/Modules/QuestieEventHandler.lua:76>
[string "=[C]"]: ?
[string "@Interface/AddOns/Capping/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...ing/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15>
[string "@Interface/AddOns/Capping/Libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function `Fire'
[string "@Interface/AddOns/ElvUI_Libraries/Core/Ace3/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...UI_Libraries/Core/Ace3/AceEvent-3.0/AceEvent-3.0.lua:119>

Renier747 · Answer 3 · 2023-03-07T10:53:22.000Z

This worked fine before WOTLK had an update.

Renier747 · Answer 4 · 2023-03-07T17:27:59.000Z

Hi, It is when I accept multiple quests from the DK quest giver on the flying ship in Icecrown. If for example he has 5 quests and I click to accept 5 with auto accept on. It works fine. When I click an additional time it bugs out. If I have an uncompleted quest for example I did not complete Neutralizing the Plague but I completed all the others, It bugs out when I try to hand in the quests with auto-complete on. If I just manually select the quest after Neutralizing the plague it works again. I don't use a macro. I simply enable auto-accept and auto-complete on Questie. Hope this helps. Renier

…

________________________________ From: Dyaxler ***@***.***> Sent: 07 March 2023 15:30 To: Questie/Questie ***@***.***> Cc: Renier747 ***@***.***>; State change ***@***.***> Subject: Re: [Questie/Questie] Questie LUA ERROR when auto accepting multiple quests (Issue #4682) I just finished looking over this debug stack and I need more information. 1. Which quest is this for? 2. Is this a quest where you turn in multiple "stacks" of items to advance Rep? Like the Uldar Relics for the Sons of Hodir? 3. If #2<#2> is yes, are you using a macro to speed up the turn in process or are you mashing the Gossip bubble? The error in question is freaking out because the table index isn't returning the Quest Title. No change has been made to the Blizzard API we're using to get that data. The only reason I can see why it would be wrong or why it's returning a Boolean value vs a String is if the API isn't returning the data fast enough. Macro mash? Button mash? It's happened before. Blizzard will sometimes throttle an API without telling the Addon community. https://wowpedia.fandom.com/wiki/API_C_GossipInfo.GetActiveQuests The first return from this API is the Quest Title in the form of a String... so shrug — Reply to this email directly, view it on GitHub<#4682 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXL5YAT2LXWJS6FZ7VWZJJ3W25ICXANCNFSM6AAAAAAVSJ22BE>. You are receiving this because you modified the open/close state.Message ID: ***@***.***>

Dyaxler · Answer 5 · 2023-03-07T15:30:40.000Z

I just finished looking over this debug stack and I need more information. It's hitting the CompleteQuestFromGossip function so are you getting a quest or turning one in or both?

Which quest is this for?
Were you in combat?
Is this a Rep turn in?

The error in question is freaking out because the table index isn't returning the Quest Title. No change has been made to the Blizzard API we're using to get that data. The only reason I can see why it would be wrong or why it's returning a Boolean value vs a String is if the API isn't returning the data fast enough. Macro mash? Button mash? It's happened before. Blizzard will sometimes throttle an API without telling the Addon community.

https://wowpedia.fandom.com/wiki/API_C_GossipInfo.GetActiveQuests

The first return from this API is the Quest Title in the form of a String... so shrug

BreakBB · Answer 6 · 2023-03-08T11:03:15.000Z

Hey @Dyaxler

No change has been made to the Blizzard API we're using to get that data.

This is not entirely correct. With the start of P2 of Wotlk Blizzard added the Dragonflight API which is totally new for us to use. The we QuestieCompat module used the new C_Gossip stuff and I have a feeling the API is not working correctly on Blizzards side.
I noted this somewhere else but we are definitely getting wrong values in some situations.

So adding a check for the title is fine to not crash on users, but we need to validate the root cause.

Renier747 · Answer 7 · 2023-03-08T13:39:07.000Z

Thanks, guys,

WOTLK will be lost without Questie.

BreakBB · Answer 8 · 2023-03-09T06:32:47.000Z

Merging with #4626

Share to

Bug description

Screenshots

Questie & WoW version