Need Feedback - Tell us what you think. Achievements [quantityProgress / quantityNeeded]
Dyaxler opened this issue · 7 comments
Description
All the number criteria-based Achievements all indicate a quantityNeeded
in the Objective Text. What I propose is to trim the quantityNeeded
tag off of the Objective Tags. So instead of having something like "Loot 1000 Gold: 456/1000" the tag would simply be "Loot 1000 Gold: 456".
The above example is only for Money and the modification only exists for me currently on my local build. I can apply this same method for all other number criteria-based Achievements.
Thoughts?
Keep the formatting consistent.
So like, if the objective is "Complete 50 Quests" or "Unarmed Skill to 400"...
don't use the little >, just indent the objective and have it be the same as quest objectives.
**Complete 50 Quests**
Quests Complete : 49 / 50
**Raise Unarmed to 400**
Unarmed Skill : 374 / 400
**Collect 5,000 Gold**
Gold Collected : 4,999 / 5,000
For better legibility, it's best to add spaces around " : " and " / " too. (=
Also... check out how adding a space in GitHub makes the lines easier to read. You should add 1 line height between objectives and quests by default. It's a lot easier to read.
**Complete 50 Quests**
Quests Complete : 49 / 50
**Raise Unarmed to 400**
Unarmed Skill : 374 / 400
**Collect 5,000 Gold**
Gold Collected : 4,999 / 5,000
I also think we should try to keep it consistent with other objectives.
The money string format looks nice but is a bit verbose, that's the downside 🤷
But it's also quite the edge case because there aren't many money objectives and I guess even less people actively tracking these outside of the few quests.
I thought I implied that this change would be applied to all achievements to keep things consistent... if everyone liked the idea.
@Gogo1951 To keep the tracker code as slim as possible we try and avoid any massive text formatting modifications. In short, we try and use the raw text from the DB as much as possible. Tweaking the spacing has been on my mind but I'm more focused on getting the tracker stable for now. The idea above just popped into my head and I wanted to get it on paper and let everyone chew on it. Something I want to do more of in the future instead of surprising everyone with something new.
I like this change but with all the legibility modifications that @Gogo1951 mentioned.
FWIW... I don't like the ">" either but I wanted to give SOME indication that the line was split.