Questie

Questie

116M Downloads

After a longer session, auto-turn-in & auto-quest-accept stop working

Gogo1951 opened this issue ยท 3 comments

commented

In Wrath.

This bug is similar to the bug we had back in Vanilla, where after a long session things just sort of stopped working.

After you quest for an hour or so, all of a sudden the auto-turn-in doesn't work for any quest until you do a reload.

I just assumed it was an issue on my side and with the taint issues in the past it was hard to be sure, but after my questing buddy in Discord reported it... I started looking more closely.

From a clean session start, we both hit the issue at different times, but by 1-2 hours into the session we had both experienced auto-turn-in / auto-quest-accept stop working. I also saw this when questing solo.

No Lua errors or taint reported.

commented

We were both running Elv, Details, DBM, Weak Auras... just the basics. I know he's not a big add-on guy.

commented

There were some performance issues we caught this morning, caused by me... MY BAD! :D It's been corrected in the newest version...

I know this is in relation to Auto-Quest but the performance issues introduced by my mistake could lead to timing issues for back end updates and certain functions might not fire in the right order. At least I hope our fix for my mistake will solve this.

commented

Actually, this one was most likely related to the new dialog icon feature, because I made a really stupid logic error that resulted in us spamming the API exponentially as the session went on, based on how many dialog windows you opened and how many quests were listed in each. This almost certainly broke QuestieAuto when it got to massive numbers, as QuestieAuto would run after the dialog icon code, and if that code broke, it would probably also prevent Auto from running after.

This would have been introduced in 7.5.0, and was fixed in 8.4.0 with f471b00. If it's still happening, feel free to reopen.